Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add notes to rules #1026

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Conversation

nstelter-slac
Copy link
Collaborator

@nstelter-slac nstelter-slac commented Aug 22, 2023

Add notes field to notes menu so description for current rule can be added.

@nstelter-slac
Copy link
Collaborator Author

should there be a limit on note size?
could potentially cause perf issue if user starts adding long notes to many widgets.

Add notes field to notes menu so description of rules can be added.
Copy link
Collaborator

@YektaY YektaY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! thank you :)

@YektaY YektaY merged commit 32262f5 into slaclab:master Aug 29, 2023
18 checks passed
@Ryan-McClanahan
Copy link
Contributor

limit on note size is probably a good idea! IDK what it would be, I'm sure 100 characters would be enough

@nstelter-slac nstelter-slac deleted the notes_to_rules branch September 1, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants