PERF: create unit menu on-demand for QLineEdit #1027
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
We noticed that a bunch of
QMenu
instances were in our typhos test suite at the top-level (QApplication.instance().topLevelWidgets()
).While tangential to the issue we were investigating in that repository, it seems unnecessary for PyDM to create these at
__init__
time.This PR
This PR creates the unit conversion menu on-demand.
Testing