-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Timeplot auto scrolling #1076
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdomke
commented
May 3, 2024
zdomke
commented
May 3, 2024
…meplot_auto_scroll Conflicts: pydm/widgets/archiver_time_plot.py
Rebased timeplot_auto_scroll to slaclab:master |
jbellister-slac
approved these changes
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is different behavior from the current fixedRate
update that we may want to surface in designer in a future update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1601
Add an autoscroll feature to PyDMTimePlot and PyDMArchiverTimePlot.
When enabling autoscroll a refresh rate, timespan, and padding are provided. A QTimer is created that will call a function to shift the plot along the X-axis, always showing the given timespan. The QTimer calls this function after <refresh_rate> seconds. The padding will show that much space to the right of the rightmost datapoint.
By default the padding is 10% of the timespan. If the padding value is less than the refresh_rate, then the padding size is the refresh_rate value. This prevents getting newer data than the X-axis shows, which would cause the plot to "jump" to the right frequently.