FIX: Addressed two bugs on the slider. Middle click to see PV name and click and drag on the slider handle #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le of the slider to be able to drag it and the other to be able to middle click and see the PV name attached to the slider
…nts to the slider. all changes are from requestsand notes which came up during code review
|
thank you for the notes, I believe I have addressed everything now, let me know if there is anything else. |
nstelter-slac
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs with the PyDMSlider. The first was with middle clicking on the slider, which did nothing, indeed of the expected behavior of displaying the PV name. The second was that the Slider was unable to be dragged. Now if a user clicks then holds on the handle of the slider they are able to drag the slider.