From eb1204b25b06fd3f1844b481782ab608c5421656 Mon Sep 17 00:00:00 2001
From: Danny Baumann <dannybaumann@web.de>
Date: Tue, 5 Nov 2019 09:18:13 +0100
Subject: [PATCH] Add support for multiple issue templates.

Closes #923
---
 .../gh4a/activities/IssueEditActivity.java    | 402 ++++++++++++++----
 .../main/res/layout/row_issue_template.xml    |  22 +
 app/src/main/res/values/strings.xml           |   1 +
 3 files changed, 353 insertions(+), 72 deletions(-)
 create mode 100644 app/src/main/res/layout/row_issue_template.xml

diff --git a/app/src/main/java/com/gh4a/activities/IssueEditActivity.java b/app/src/main/java/com/gh4a/activities/IssueEditActivity.java
index c030e4f3d..36bbc1207 100644
--- a/app/src/main/java/com/gh4a/activities/IssueEditActivity.java
+++ b/app/src/main/java/com/gh4a/activities/IssueEditActivity.java
@@ -37,9 +37,13 @@
 import androidx.viewpager.widget.PagerAdapter;
 import androidx.appcompat.app.AlertDialog;
 
+import android.os.Parcel;
+import android.os.Parcelable;
+import android.text.TextUtils;
 import android.view.LayoutInflater;
 import android.view.View;
 import android.view.ViewGroup;
+import android.widget.ArrayAdapter;
 import android.widget.EditText;
 import android.widget.ImageView;
 import android.widget.TextView;
@@ -72,10 +76,14 @@
 
 import java.net.HttpURLConnection;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.Collections;
 import java.util.List;
 import java.util.Locale;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
 
+import io.reactivex.Flowable;
 import io.reactivex.Single;
 import retrofit2.Response;
 
@@ -97,6 +105,16 @@ public static Intent makeEditIntent(Context context, String repoOwner,
                 .putExtra("issue", issue);
     }
 
+    private interface OnAssigneesLoaded {
+        void handleLoad(List<User> assignees);
+    }
+    private interface OnLabelsLoaded {
+        void handleLoad(List<Label> labels);
+    }
+    private interface OnMilestonesLoaded {
+        void handleLoad(List<Milestone> milestones);
+    }
+
     private static final int REQUEST_MANAGE_LABELS = 1000;
     private static final int REQUEST_MANAGE_MILESTONES = 1001;
 
@@ -110,9 +128,11 @@ public static Intent makeEditIntent(Context context, String repoOwner,
     private String mRepoName;
 
     private boolean mIsCollaborator;
-    private List<Milestone> mAllMilestone;
-    private List<User> mAllAssignee;
-    private List<Label> mAllLabels;
+
+    private Single<List<User>> mAssigneeSingle;
+    private Single<List<Label>> mLabelSingle;
+    private Single<List<Milestone>> mMilestoneSingle;
+
     private Issue mEditIssue;
     private Issue mOriginalIssue;
 
@@ -188,7 +208,8 @@ public void onCreate(Bundle savedInstanceState) {
         loadCollaboratorStatus(false);
 
         if (savedInstanceState == null && !isInEditMode()) {
-            loadIssueTemplate();
+            loadIssueTemplates();
+            mTitleView.setEnabled(false);
             mDescView.setEnabled(false);
             mDescView.setHint(getString(R.string.issue_loading_template_hint));
         }
@@ -273,9 +294,9 @@ protected boolean canSwipeToRefresh() {
 
     @Override
     public void onRefresh() {
-        mAllAssignee = null;
-        mAllMilestone = null;
-        mAllLabels = null;
+        mAssigneeSingle = null;
+        mLabelSingle = null;
+        mMilestoneSingle = null;
         mIsCollaborator = false;
         loadCollaboratorStatus(true);
         super.onRefresh();
@@ -342,12 +363,12 @@ protected void onActivityResult(int requestCode, int resultCode, Intent data) {
         if (requestCode == REQUEST_MANAGE_LABELS) {
             if (resultCode == RESULT_OK) {
                 // Require reload of labels
-                mAllLabels = null;
+                mLabelSingle = null;
             }
         } else if (requestCode == REQUEST_MANAGE_MILESTONES) {
             if (resultCode == RESULT_OK) {
                 // Require reload of milestones
-                mAllMilestone = null;
+                mMilestoneSingle = null;
             }
         } else {
             super.onActivityResult(requestCode, resultCode, data);
@@ -355,37 +376,31 @@ protected void onActivityResult(int requestCode, int resultCode, Intent data) {
     }
 
     private void showMilestonesDialog() {
-        if (mAllMilestone == null) {
-            loadMilestones();
-        } else {
+        loadMilestones(milestones -> {
             MilestoneEditDialogFragment
-                    .newInstance(mEditIssue.milestone(), mAllMilestone)
+                    .newInstance(mEditIssue.milestone(), milestones)
                     .show(getSupportFragmentManager(), "milestoneedit");
-        }
+        });
     }
 
     private void showAssigneesDialog() {
-        if (mAllAssignee == null) {
-            loadPotentialAssignees();
-        } else {
+        loadPotentialAssignees(assignees -> {
             final List<User> oldAssigneeList = mEditIssue.assignees() != null
                     ? mEditIssue.assignees() : Collections.emptyList();
             AssigneeEditDialogFragment
-                    .newInstance(oldAssigneeList, mAllAssignee)
+                    .newInstance(oldAssigneeList, assignees)
                     .show(getSupportFragmentManager(), "assigneeedit");
-        }
+        });
     }
 
     private void showLabelDialog() {
-        if (mAllLabels == null) {
-            loadLabels();
-        } else {
+        loadLabels(labels -> {
             final List<Label> selectedLabels = mEditIssue.labels() != null
                     ? mEditIssue.labels() : Collections.emptyList();
             LabelEditDialogFragment
-                    .newInstance(selectedLabels, mAllLabels)
+                    .newInstance(selectedLabels, labels)
                     .show(getSupportFragmentManager(), "labeledit");
-        }
+        });
     }
 
     private void updateMilestone(Milestone newMilestone) {
@@ -518,78 +533,321 @@ private void loadCollaboratorStatus(boolean force) {
                 }, this::handleLoadFailure);
     }
 
-    private void loadLabels() {
+    private void loadLabels(OnLabelsLoaded callback) {
         final IssueLabelService service = ServiceFactory.get(IssueLabelService.class, false);
-        registerTemporarySubscription(ApiHelpers.PageIterator
-                .toSingle(page -> service.getRepositoryLabels(mRepoOwner, mRepoName, page))
-                .compose(RxUtils::doInBackground)
-                .compose(RxUtils.wrapWithProgressDialog(this, R.string.loading_msg))
-                .subscribe(result -> {
-                    mAllLabels = result;
-                    showLabelDialog();
-                }, this::handleLoadFailure));
+        if (mLabelSingle == null) {
+            mLabelSingle = ApiHelpers.PageIterator
+                    .toSingle(page -> service.getRepositoryLabels(mRepoOwner, mRepoName, page))
+                    .compose(RxUtils::doInBackground)
+                    .compose(RxUtils.wrapWithProgressDialog(this, R.string.loading_msg))
+                    .cache();
+        }
+        registerTemporarySubscription(
+                mLabelSingle.subscribe(result -> callback.handleLoad(result), this::handleLoadFailure));
     }
 
-    private void loadMilestones() {
+    private void loadMilestones(OnMilestonesLoaded callback) {
         final IssueMilestoneService service = ServiceFactory.get(IssueMilestoneService.class, false);
-        registerTemporarySubscription(ApiHelpers.PageIterator
-                .toSingle(page -> service.getRepositoryMilestones(mRepoOwner, mRepoName, "open", page))
-                .compose(RxUtils::doInBackground)
-                .compose(RxUtils.wrapWithProgressDialog(this, R.string.loading_msg))
-                .subscribe(result -> {
-                    mAllMilestone = result;
-                    showMilestonesDialog();
-                }, this::handleLoadFailure));
+        if (mMilestoneSingle == null) {
+            mMilestoneSingle = ApiHelpers.PageIterator
+                    .toSingle(page -> service
+                            .getRepositoryMilestones(mRepoOwner, mRepoName, "open", page))
+                    .compose(RxUtils::doInBackground)
+                    .compose(RxUtils.wrapWithProgressDialog(this, R.string.loading_msg))
+                    .cache();
+        }
+        registerTemporarySubscription(
+                mMilestoneSingle.subscribe(result -> callback.handleLoad(result), this::handleLoadFailure));
     }
 
-    private void loadPotentialAssignees() {
+    private void loadPotentialAssignees(OnAssigneesLoaded callback) {
         final RepositoryCollaboratorService service =
                 ServiceFactory.get(RepositoryCollaboratorService.class, false);
-        registerTemporarySubscription(ApiHelpers.PageIterator
-                .toSingle(page -> service.getCollaborators(mRepoOwner, mRepoName, page))
-                .compose(RxUtils::doInBackground)
+
+        if (mAssigneeSingle == null) {
+            mAssigneeSingle = ApiHelpers.PageIterator
+                    .toSingle(page -> service.getCollaborators(mRepoOwner, mRepoName, page))
+                    .compose(RxUtils::doInBackground)
+                    .compose(RxUtils.wrapWithProgressDialog(this, R.string.loading_msg))
+                    .map(assignees -> {
+                        User creator = mEditIssue.user();
+                        if (creator != null && !assignees.contains(creator)) {
+                            assignees.add(creator);
+                        }
+                        return assignees;
+                    })
+                    .cache();
+        }
+
+        registerTemporarySubscription(
+                mAssigneeSingle.subscribe(result -> callback.handleLoad(result), this::handleLoadFailure));
+    }
+
+    private void loadIssueTemplates() {
+        registerTemporarySubscription(getIssueTemplatesSingle("/.github")
+                .flatMap(opt -> opt.orOptionalSingle(() -> getIssueTemplatesSingle("")))
+                .flatMap(opt -> opt.orOptionalSingle(() -> getIssueTemplatesSingle("/docs")))
                 .compose(RxUtils.wrapWithProgressDialog(this, R.string.loading_msg))
                 .subscribe(result -> {
-                    mAllAssignee = result;
-                    User creator = mEditIssue.user();
-                    if (creator != null && !mAllAssignee.contains(creator)) {
-                        mAllAssignee.add(creator);
+                    if (result.isPresent() && !result.get().isEmpty()) {
+                        List<IssueTemplate> templates = result.get();
+                        if (templates.size() == 1) {
+                            handleIssueTemplateSelected(templates.get(0));
+                        } else {
+                            IssueTemplateSelectionDialogFragment f =
+                                    IssueTemplateSelectionDialogFragment.newInstance(templates);
+                            f.show(getSupportFragmentManager(), "template-selection");
+                        }
+                    } else {
+                        handleIssueTemplateSelected(null);
                     }
-                    showAssigneesDialog();
                 }, this::handleLoadFailure));
     }
 
-    private void loadIssueTemplate() {
-        RepositoryContentService service = ServiceFactory.get(RepositoryContentService.class, false);
+    private void handleIssueTemplateSelected(IssueTemplate template) {
+        mTitleView.setEnabled(true);
+        mDescView.setHint(null);
+        mDescView.setEnabled(true);
+        if (template == null) {
+            return;
+        }
 
-        registerTemporarySubscription(getIssueTemplateContentSingle("/.github")
-                .flatMap(opt -> opt.orOptionalSingle(() -> getIssueTemplateContentSingle("")))
-                .flatMap(opt -> opt.orOptionalSingle(() -> getIssueTemplateContentSingle("/docs")))
-                .flatMap(opt -> opt.flatMap(c -> {
-                    //noinspection CodeBlock2Expr
-                    return service.getContents(mRepoOwner, mRepoName, c.path(), null)
-                            .map(ApiHelpers::throwOnFailure)
-                            .compose(RxUtils::doInBackground);
-                }))
-                .map(opt -> opt.map(c -> StringUtils.fromBase64(c.content())))
-                .compose(RxUtils.wrapWithProgressDialog(this, R.string.loading_msg))
-                .subscribe(result -> {
-                    mDescView.setHint(null);
-                    mDescView.setEnabled(true);
-                    mDescView.setText(result.orNull());
-                }, this::handleLoadFailure));
+        mTitleView.setText(template.title);
+        mDescView.setText(template.content);
+        if (!template.defaultAssignees.isEmpty()) {
+            loadPotentialAssignees(assignees -> {
+                final List<User> validAssignees = new ArrayList<>();
+                for (User potentialAssignee : assignees) {
+                    if (template.defaultAssignees.contains(potentialAssignee.login())) {
+                        validAssignees.add(potentialAssignee);
+                    }
+                }
+                if (!validAssignees.isEmpty()) {
+                    mEditIssue = mEditIssue.toBuilder()
+                            .assignees(validAssignees)
+                            .build();
+                }
+            });
+        }
+        if (!template.defaultLabels.isEmpty()) {
+            loadLabels(labels -> {
+                final List<Label> validLabels = new ArrayList<>();
+                for (Label label : labels) {
+                    if (template.defaultLabels.contains(label.name())) {
+                        validLabels.add(label);
+                    }
+                }
+                if (!validLabels.isEmpty()) {
+                    mEditIssue = mEditIssue.toBuilder()
+                            .labels(validLabels)
+                            .build();
+                }
+            });
+        }
     }
 
-    private Single<Optional<Content>> getIssueTemplateContentSingle(String path) {
+    private Single<Optional<List<IssueTemplate>>> getIssueTemplatesSingle(String path) {
         RepositoryContentService service = ServiceFactory.get(RepositoryContentService.class, false);
         return ApiHelpers.PageIterator
                 .toSingle(page -> service.getDirectoryContents(mRepoOwner, mRepoName, path, null, page))
+                .compose(RxUtils.filterAndMapToFirst(c -> c.name().toLowerCase(Locale.US).startsWith("issue_template")))
+                .flatMap(contentOpt -> contentOpt.flatMap(content -> {
+                    if (content.type() == ContentType.Directory) {
+                        return ApiHelpers.PageIterator
+                                .toSingle(page -> service.getDirectoryContents(mRepoOwner, mRepoName, content.path(), null, page));
+                    } else {
+                        return Single.just(Arrays.asList(content));
+                    }
+                }))
+                .map(contentsOpt -> contentsOpt.map(contents -> {
+                    List<Content> files = new ArrayList<>();
+                    for (Content c : contents) {
+                        if (c.type() == ContentType.File && c.name().endsWith(".md")) {
+                            files.add(c);
+                        }
+                    }
+                    return files;
+                }))
+                .flatMap(contentsOpt -> contentsOpt.flatMap(contents -> {
+                    List<Single<IssueTemplate>> result = new ArrayList<>();
+                    for (Content c : contents) {
+                        result.add(parseTemplate(service, c));
+                    }
+                    return Flowable.fromIterable(result)
+                            .flatMap(flowable -> flowable.toFlowable())
+                            .filter(template -> template != null)
+                            .toList();
+                }))
                 .compose(RxUtils::doInBackground)
-                .compose(RxUtils.filterAndMapToFirst(
-                        c -> c.type() == ContentType.File && c.name().toLowerCase(Locale.US).startsWith("issue_template")))
                 .compose(RxUtils.mapFailureToValue(HttpURLConnection.HTTP_NOT_FOUND, Optional.absent()));
     }
 
+    private Single<IssueTemplate> parseTemplate(RepositoryContentService service, Content content) {
+        return service.getContents(mRepoOwner, mRepoName, content.path(), null)
+            .map(ApiHelpers::throwOnFailure)
+            .map(fileContent -> StringUtils.fromBase64(fileContent.content()))
+            .map(contentString -> IssueTemplate.parse(contentString))
+            .compose(RxUtils::doInBackground);
+    }
+
+    private static class IssueTemplate implements Parcelable {
+        private static final Pattern FRONT_MATTER_PATTERN =
+                Pattern.compile("(---\n)(.*?\n)((---)|(\\.\\.\\.))\n?(.*)", Pattern.DOTALL);
+
+        String content;
+        String name;
+        String description;
+        String title;
+        final List<String> defaultLabels = new ArrayList<>();
+        final List<String> defaultAssignees = new ArrayList<>();
+
+        public static IssueTemplate parse(String contentString) {
+            IssueTemplate t = new IssueTemplate(contentString);
+            return t.name != null ? t : null;
+        }
+
+        private IssueTemplate(String contentString) {
+            Matcher matcher = FRONT_MATTER_PATTERN.matcher(contentString);
+            if (matcher.matches()) {
+                content = matcher.group(6);
+                for (String line : matcher.group(2).split("\n")) {
+                    int colonPos = line.indexOf(": ");
+                    if (colonPos > 0) {
+                        String key = line.substring(0, colonPos);
+                        boolean isQuoted = line.charAt(colonPos + 2) == '"'
+                                || line.charAt(colonPos + 2) == '\'';
+                        String value = isQuoted
+                                ? line.substring(colonPos + 3, line.length() - 1)
+                                : line.substring(colonPos + 2);
+                        switch (key) {
+                            case "name": name = value; break;
+                            case "about": description = value; break;
+                            case "title": title = value; break;
+                            case "labels": splitAndFillList(value, defaultLabels); break;
+                            case "assignees": splitAndFillList(value, defaultAssignees); break;
+                        }
+                    }
+                }
+            } else {
+                content = contentString;
+            }
+        }
+
+        private IssueTemplate(Parcel parcel) {
+            content = parcel.readString();
+            name = parcel.readString();
+            description = parcel.readString();
+            title = parcel.readString();
+            parcel.readStringList(defaultLabels);
+            parcel.readStringList(defaultAssignees);
+        }
+
+        @Override
+        public int describeContents() {
+            return 0;
+        }
+
+        @Override
+        public void writeToParcel(Parcel parcel, int flags) {
+            parcel.writeString(content);
+            parcel.writeString(name);
+            parcel.writeString(description);
+            parcel.writeString(title);
+            parcel.writeStringList(defaultLabels);
+            parcel.writeStringList(defaultAssignees);
+        }
+
+        public static Parcelable.Creator CREATOR = new Parcelable.Creator<IssueTemplate>() {
+            @Override
+            public IssueTemplate createFromParcel(Parcel parcel) {
+                return new IssueTemplate(parcel);
+            }
+
+            @Override
+            public IssueTemplate[] newArray(int count) {
+                return new IssueTemplate[count];
+            }
+        };
+
+        private static void splitAndFillList(String input, List<String> list) {
+            for (String part : input.split(",")) {
+                String trimmed = part.trim();
+                if (!trimmed.isEmpty()) {
+                    list.add(trimmed);
+                }
+            }
+        }
+    }
+
+    public static class IssueTemplateSelectionDialogFragment extends DialogFragment
+            implements DialogInterface.OnClickListener, DialogInterface.OnCancelListener {
+        private List<IssueTemplate> mTemplates;
+
+        public static IssueTemplateSelectionDialogFragment newInstance(List<IssueTemplate> templates) {
+            IssueTemplateSelectionDialogFragment f = new IssueTemplateSelectionDialogFragment();
+            Bundle args = new Bundle();
+            args.putParcelableArrayList("templates", new ArrayList<>(templates));
+            f.setArguments(args);
+            return f;
+        }
+
+        @NonNull
+        @Override
+        public Dialog onCreateDialog(Bundle savedInstanceState) {
+            Bundle args = getArguments();
+            mTemplates = args.getParcelableArrayList("templates");
+
+            return new AlertDialog.Builder(getContext())
+                    .setTitle(R.string.issue_template_dialog_title)
+                    .setSingleChoiceItems(new Adapter(getContext(), mTemplates), -1, this)
+                    .setOnCancelListener(this)
+                    .setNegativeButton(R.string.cancel, null)
+                    .create();
+        }
+
+        @Override
+        public void onClick(DialogInterface dialog, int which) {
+            ((IssueEditActivity) getActivity()).handleIssueTemplateSelected(mTemplates.get(which));
+            dialog.dismiss();
+        }
+
+        @Override
+        public void onCancel(@NonNull DialogInterface dialog) {
+            super.onCancel(dialog);
+            ((IssueEditActivity) getActivity()).handleIssueTemplateSelected(null);
+        }
+
+        private static class Adapter extends ArrayAdapter<IssueTemplate> {
+            private LayoutInflater mInflater;
+
+            public Adapter(Context context, List<IssueTemplate> templates) {
+                super(context, R.layout.row_issue_template, templates);
+                mInflater = LayoutInflater.from(context);
+            }
+
+            @NonNull
+            @Override
+            public View getView(int position, @Nullable View convertView, @NonNull ViewGroup parent) {
+                final View view;
+                if (convertView == null) {
+                    view = mInflater.inflate(R.layout.row_issue_template, parent, false);
+                } else {
+                    view = convertView;
+                }
+
+                TextView title = view.findViewById(R.id.title);
+                TextView description = view.findViewById(R.id.description);
+                IssueTemplate template = getItem(position);
+
+                title.setText(template.name);
+                description.setText(template.description);
+                description.setVisibility(TextUtils.isEmpty(template.description) ? View.GONE : View.VISIBLE);
+
+                return view;
+            }
+        }
+    }
+
     private class EditPagerAdapter extends PagerAdapter {
         @Override
         public Object instantiateItem(ViewGroup container, int position) {
diff --git a/app/src/main/res/layout/row_issue_template.xml b/app/src/main/res/layout/row_issue_template.xml
new file mode 100644
index 000000000..2b596df0d
--- /dev/null
+++ b/app/src/main/res/layout/row_issue_template.xml
@@ -0,0 +1,22 @@
+<?xml version="1.0" encoding="utf-8"?>
+<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
+    android:orientation="vertical"
+    android:layout_width="match_parent"
+    android:layout_height="wrap_content"
+    android:paddingHorizontal="@dimen/content_padding"
+    android:paddingTop="4dp"
+    android:paddingBottom="4dp">
+
+    <com.gh4a.widget.StyleableTextView
+        android:id="@+id/title"
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:textAppearance="@style/TextAppearance.AppCompat.Body1" />
+
+    <com.gh4a.widget.StyleableTextView
+        android:id="@+id/description"
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:textAppearance="@style/TextAppearance.AppCompat.Caption" />
+
+</LinearLayout>
\ No newline at end of file
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index db6e284db..e19cfa8c4 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -413,6 +413,7 @@
     <string name="issue_no_description">No description provided.</string>
     <string name="close_issue_confirm">Do you really want to close this issue?</string>
     <string name="reopen_issue_confirm">Do you really want to reopen this issue?</string>
+    <string name="issue_template_dialog_title">Select issue type</string>
 
     <!-- Pull Request -->
     <string name="pull_request_title">Pull Request</string>