Read type from column_type
besides type
for better supporting belongs_to
#42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on the discussion on #36
The PR intends to better support
belongs_to
.To get the type, we first read
column_type
from opts, and only if it's not available we read type from opts. This way, we can usecolumn_type
everywhere if we want to, but we can also keep using type and not break existing code.For belongs_to, the user can use
belongs_to(:post, Post, type: TypeID)
to use the default type for thecolumn_type
or specify it:belongs_to(:post, Post, type: TypeID, column_type: :string)
My comment here describes a reproducible example of the issue and its solution #36 (comment)