Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smbios support #1

Merged
merged 2 commits into from
May 23, 2024
Merged

Add smbios support #1

merged 2 commits into from
May 23, 2024

Conversation

germag
Copy link

@germag germag commented May 22, 2024

This updates the .DSC and .FDF file to work with the current submodules, and add support for smbios.

I also included a build file 'edk2-build.krun' that can be use with the edk2-build.py from:

https://gitlab.com/kraxel/edk2-build-config

For instance:

edk2-build.py --config edk2-build.krun
-m armvirt
--release-date 22/05/2024
--version-override 20240522

then you will get both KRUN_EFI.silent.fd and KRUN_EFI.fd inside RHEL-9/aarch64 directory

@@ -235,7 +235,7 @@
# this permits setting the PCD in unreachable code without pulling in dynamic PCD support
gEfiSecurityPkgTokenSpaceGuid.PcdTpmBaseAddress|0x0

gEfiMdeModulePkgTokenSpaceGuid.PcdResizeXterm|FALSE
# gEfiMdeModulePkgTokenSpaceGuid.PcdResizeXterm|FALSE
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change related to SMBIOS?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nop, I'll split the commit

<LibraryClasses>
NULL|ArmVirtPkg/Library/TerminalPcdProducerLib/TerminalPcdProducerLib.inf
}
MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question

Update the .DSC file to be abale to compile after doing:
git submodule update --init

It also add a build file 'edk2-build.krun' that can be use
with the `edk2-build.py` from:

https://gitlab.com/kraxel/edk2-build-config

For instance:

edk2-build.py --config edk2-build.krun \
              -m armvirt \
              --release-date 22/05/2024 \
              --version-override 20240522

then you will get both KRUN_EFI.silent.fd and KRUN_EFI.fd
inside RHEL-9/aarch64 directory

Signed-off-by: German Maglione <gmaglione@redhat.com>
Adding support for smbios, besides updating .DSC and .FDF
files. It replaces the `SmbiosTablePublishEntry()` function
to search for the SMBIOS tables at address 0x4000F000.

WARNING: This is an ugly hack, it removes the code for
QEMU and Cloud-Hypervisor support.

Signed-off-by: German Maglione <gmaglione@redhat.com>
@germag
Copy link
Author

germag commented May 23, 2024

v2:

  • put the SMBIOS changes on its own commit

@slp
Copy link
Owner

slp commented May 23, 2024

LGTM, thanks!

@slp slp merged commit 7200b90 into slp:krun-support May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants