New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable regression tests for BYOB #663

Open

laurentsimon opened this issue Jul 18, 2023 · 2 comments

Labels

area:tests type:feature

Contributor

laurentsimon commented Jul 18, 2023

Several of our e2e tests only use the slsa-verifier at head, e.g. https://github.com/slsa-framework/example-package/blob/main/.github/workflows/scripts/e2e.container-based.default.verify.sh#L56 and https://github.com/slsa-framework/example-package/blob/main/.github/workflows/scripts/e2e.container.default.verify.sh#L39

We need to enable them from a version.

/cc @ianlewis @asraa

laurentsimon added the e2e label

ianlewis added area:tests type:feature and removed e2e labels

laurentsimon changed the title ~~[e2e] Enable regression tests~~ Enable regression tests for BYOB

laurentsimon transferred this issue from slsa-framework/slsa-github-generator

Contributor Author

laurentsimon commented Jul 19, 2023

We also need regression tests in this repo

Contributor Author

laurentsimon commented Jul 19, 2023

https://github.com/slsa-framework/example-package/blob/main/.github/workflows/verifier-e2e.all.workflow_dispatch.main.all.slsa3.yml is for generating regression test as linked in https://github.com/slsa-framework/slsa-github-generator/blob/main/RELEASE.md#update-verifier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment