Skip to content

Commit

Permalink
fix: linter and type export errors
Browse files Browse the repository at this point in the history
  • Loading branch information
MarcMcIntosh committed Jan 10, 2024
1 parent 556a17e commit 8e54c7f
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 15 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ jobs:
node-version: ${{ matrix.node-version }}
cache: "npm"
- run: npm ci
- run: npm run test
- run: npm run format:check
- run: npm run types
- run: npm run lint
- run: npm run test
- run: npm run build
16 changes: 9 additions & 7 deletions src/components/ScrollArea/ScrollArea.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,15 @@ import classNames from "classnames";
import React from "react";
import styles from "./ScrollArea.module.css";

type ScrollAreaProps = React.ComponentProps<typeof RadixScrollArea>;
export const ScrollArea: React.FC<
ScrollAreaProps & {
className?: string;
scrollbars?: "vertical" | "horizontal" | "both" | undefined;
}
> = ({ scrollbars, className, ...props }) => {
export type ScrollAreaProps = React.ComponentProps<typeof RadixScrollArea> & {
className?: string;
scrollbars?: "vertical" | "horizontal" | "both" | undefined;
};
export const ScrollArea: React.FC<ScrollAreaProps> = ({
scrollbars,
className,
...props
}) => {
const isVertical = scrollbars !== undefined && scrollbars === "vertical";

return (
Expand Down
2 changes: 1 addition & 1 deletion src/components/Select/Select.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from "react";
import { Select as RadixSelect } from "@radix-ui/themes";

type SelectProps = React.ComponentProps<typeof RadixSelect.Root> & {
export type SelectProps = React.ComponentProps<typeof RadixSelect.Root> & {
onChange: (value: string) => void;
options: string[];
title?: string;
Expand Down
2 changes: 1 addition & 1 deletion src/components/TextArea/TextArea.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { TextArea as RadixTextArea } from "@radix-ui/themes";
import classNames from "classnames";
import styles from "./TextArea.module.css";

type TextAreaProps = React.ComponentProps<typeof RadixTextArea> & {
export type TextAreaProps = React.ComponentProps<typeof RadixTextArea> & {
className?: string;
};

Expand Down
5 changes: 1 addition & 4 deletions tsconfig.node.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,7 @@
"module": "ESNext",
"moduleResolution": "bundler",
"allowSyntheticDefaultImports": true,
"strict": true,
"paths": {
"*": ["node_modules/*"]
}
"strict": true
},
"include": ["vite.config.ts", "vite.library.config.ts"]
}
2 changes: 1 addition & 1 deletion vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ export default defineConfig(({ command, mode }) => {
if (command !== "serve") {
CONFIG.mode = "production";
CONFIG.define = { "process.env.NODE_ENV": "'production'" };
// eslint-disable-next-line @typescript-eslint/no-unsafe-call
CONFIG.plugins?.push([
// eslint-disable-next-line @typescript-eslint/no-unsafe-call
eslint() as PluginOption,
dts({ rollupTypes: true }),
]);
Expand Down

0 comments on commit 8e54c7f

Please sign in to comment.