Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix history limit #225

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Fix history limit #225

merged 1 commit into from
Dec 9, 2024

Conversation

MarcMcIntosh
Copy link
Collaborator

Pull Request Title

Description

The history limit was not being imposed, allowing the chat to go over 100 items.

It seems to be an issue with the reducer either mutating the proxy object or returning a different state object.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes, only code improvements)
  • Documentation update

How to Test

  • Step 1: checkout alpha, Make a lot of chats. more than 100. (checking redux for the number of entries)
  • Step 2: checkout this branch.
  • Step 3: Ask a question.
  • Step 4: The number of save chat should be 100.

Screenshots (if applicable)

Checklist

  • My code follows the code style of this project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have updated the documentation where necessary.

Linked Issues

https://refact.fibery.io/Software_Development/Week1209-by-state-420#Task/Limit-chat-history,-too-slow!-506

Additional Notes

@MarcMcIntosh MarcMcIntosh changed the base branch from main to alpha December 9, 2024 16:33
@MarcMcIntosh MarcMcIntosh marked this pull request as ready for review December 9, 2024 17:15
Copy link
Contributor

@alashchev17 alashchev17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@MarcMcIntosh MarcMcIntosh merged commit 2aa9312 into alpha Dec 9, 2024
2 checks passed
@MarcMcIntosh MarcMcIntosh deleted the fix/add-history-limit branch December 9, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants