Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat sass upgrade #125

Merged
merged 6 commits into from
Aug 29, 2021
Merged

Feat sass upgrade #125

merged 6 commits into from
Aug 29, 2021

Conversation

petrsiegl
Copy link
Contributor

  • node-sass removed (deprecated), migrated to sass
  • all packages updated (minor versions only)

Some required minor fixes are included. Everything seems to be working after update otherwise.

There is minor problem with scss compilation and bootstrap. V4 bootstrap uses division symbol / which is deprecated in sass and causes warnings. The fix should be available soon (twbs/bootstrap#34571). Until it is merged, there will be unfortunately warnings on compilation. They can be silenced by sass --quiet flag, but that disables other warnings as well.

@petrsiegl petrsiegl merged commit e285b9d into smartarch:master Aug 29, 2021
@petrsiegl petrsiegl deleted the feat-sass-upgrade branch August 29, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant