From bdc680e9b112cf6fc5397a9b062d4578e2c0db49 Mon Sep 17 00:00:00 2001 From: Morgan Kuphal Date: Thu, 14 Sep 2023 12:38:55 -0500 Subject: [PATCH 1/2] Added maximum expiration for DON hosted secrets --- .changeset/shaggy-ghosts-bake.md | 5 +++++ src/SecretsManager.ts | 10 ++++++++-- 2 files changed, 13 insertions(+), 2 deletions(-) create mode 100644 .changeset/shaggy-ghosts-bake.md diff --git a/.changeset/shaggy-ghosts-bake.md b/.changeset/shaggy-ghosts-bake.md new file mode 100644 index 0000000..9254fd6 --- /dev/null +++ b/.changeset/shaggy-ghosts-bake.md @@ -0,0 +1,5 @@ +--- +'@chainlink/functions-toolkit': patch +--- + +Added maximum expiration for DON hosted secrets diff --git a/src/SecretsManager.ts b/src/SecretsManager.ts index db7de17..e763214 100644 --- a/src/SecretsManager.ts +++ b/src/SecretsManager.ts @@ -205,8 +205,14 @@ export class SecretsManager { throw Error('slotId must be a integer of at least 0') } - if (!Number.isInteger(minutesUntilExpiration) || minutesUntilExpiration < 5) { - throw Error('minutesUntilExpiration must be an integer of at least 5') + if ( + !Number.isInteger(minutesUntilExpiration) || + minutesUntilExpiration < 5 || + minutesUntilExpiration > 100800 + ) { + throw Error( + 'minutesUntilExpiration must be an integer of at least 5 and less than 100800 (1 week)', + ) } const encryptedSecretsBase64 = Buffer.from(encryptedSecretsHexstring.slice(2), 'hex').toString( From c94dbc0839426bb2947728d98a33e2b34bd73663 Mon Sep 17 00:00:00 2001 From: Morgan Kuphal Date: Thu, 14 Sep 2023 12:43:51 -0500 Subject: [PATCH 2/2] Update SecretsManager.ts --- src/SecretsManager.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/SecretsManager.ts b/src/SecretsManager.ts index e763214..7687b49 100644 --- a/src/SecretsManager.ts +++ b/src/SecretsManager.ts @@ -208,10 +208,10 @@ export class SecretsManager { if ( !Number.isInteger(minutesUntilExpiration) || minutesUntilExpiration < 5 || - minutesUntilExpiration > 100800 + minutesUntilExpiration > 2880 ) { throw Error( - 'minutesUntilExpiration must be an integer of at least 5 and less than 100800 (1 week)', + 'minutesUntilExpiration must be an integer of at least 5 and less than 2880 (48 hours)', ) }