Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDL 0269] Feature/New vehicle data ClimateData #2491

Merged
merged 17 commits into from
Feb 9, 2021

Conversation

dboltovskyi
Copy link
Contributor

@dboltovskyi dboltovskyi commented Nov 26, 2020

ATF Test Scripts to check #3198

This PR is [ready] for review.

Summary

Updates for Vehicle Data scripts related to "[SDL 0269] New vehicle data ClimateData" feature

ATF version

7.1.0_version_bump

Changelog

  • updated common modules for VD and RGNSD tests with new parameters

CLA

@KhrystynaDubovyk
Copy link

@atiwari9 please review this PR

@atiwari9
Copy link

atiwari9 commented Dec 2, 2020

@dboltovskyi - Can you please rebase with feature/extended_vd_coverage

@dboltovskyi
Copy link
Contributor Author

@atiwari9 Please find update in 94ed2ae

@atiwari9
Copy link

atiwari9 commented Dec 7, 2020

All tests specific to climateData passed:
ClimateData_AllPass.zip

Copy link

@atiwari9 atiwari9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@LitvinenkoIra
Copy link
Contributor

@JackLivio This PR is ready for Livio review. Thank you!

Base automatically changed from feature/extended_vd_coverage to develop January 25, 2021 14:17
@ShobhitAd
Copy link
Contributor

@dboltovskyi Please resolve merge conflicts

@dboltovskyi
Copy link
Contributor Author

@ShobhitAd Please find conflicts resolved in 8e686d1

@ShobhitAd
Copy link
Contributor

@dboltovskyi Some GenericNetworkData tests seem to be failing for climateData
Checking the atf logs for 002_GetVehicleData_with_PTU_with_VDitems.lua I see this response for climateData

===== GetVehicleData_climateData : 
MOB->SDL [09-02-2021 14:06:01,120] [rpcFunction: GetVehicleData, sessionId: 1, version: 2, frameType: 1, encryption: false, serviceType: 7, frameInfo: 0, messageId: 43, binaryDataSize: 0] : {"climateData":true} 

SDL->HMI [09-02-2021 14:06:01,124] {"id":69,"jsonrpc":"2.0","method":"VehicleInfo.GetVehicleData","params":{"climateData":true}}

HMI->SDL [09-02-2021 14:06:01,124] {"result":{"method":"VehicleInfo.GetVehicleData","code":0,"resultCode":"SUCCESS","success":true,"climateData":{"externalTemperature":{},"cabinTemperature":{},"atmosphericPressure":1024}},"id":69,"jsonrpc":"2.0"}

SDL->MOB [09-02-2021 14:06:01,135] [rpcFunction: GetVehicleData, sessionId: 1, version: 2, frameType: 1, encryption: false, serviceType: 7, frameInfo: 0, messageId: 49, binaryDataSize: 0] : {"resultCode":"GENERIC_ERROR","info":"Invalid message received from vehicle","success":false}  

@dboltovskyi
Copy link
Contributor Author

@ShobhitAd Please find update in 9bfe03c

@ShobhitAd ShobhitAd merged commit 22d43eb into develop Feb 9, 2021
@ShobhitAd ShobhitAd deleted the feature/sdl_0269_new_vehicle_data_climateData branch February 9, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants