Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scripts to verify defect 3912 #2673

Merged
merged 2 commits into from
May 27, 2022
Merged

Add scripts to verify defect 3912 #2673

merged 2 commits into from
May 27, 2022

Conversation

ShobhitAd
Copy link
Contributor

ATF Test Scripts to check #3912

This PR is ready for review.

ATF version

develop (smartdevicelink/sdl_atf@2645fc1)

CLA

@ShobhitAd ShobhitAd changed the title Add test script Add scripts to verify defect 3912 May 9, 2022
Copy link
Contributor

@jacobkeeler jacobkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing a lua panic on EXTERNAL_PROPRIETARY:

--- Preconditions -----------------------------------------------------------------------------------
kill: (1374783): No such process
[11:30:59,397] Clean_environment                                                                     [SUCCESS] (403 ms)
[11:31:00,835] Update_Preloaded_PT                                                                   [SUCCESS] (403 ms)
SDL pid 1374830
tcp        0      0 127.0.0.1:8087          0.0.0.0:*               LISTEN     
SDL started
HMI initialized
HMI is ready
Mobile #1 connected
SDL allowed
[11:31:03,406] Start_SDL__HMI__connect_Mobile__start_Session                                         [SUCCESS] (1970 ms)
[11:31:05,385] Register_App                                                                          [SUCCESS] (2823 ms)
--- Test --------------------------------------------------------------------------------------------
Lua panic: ...pts/Defects/8_2/3912_PTS_With_WSS_App_Content_Length.lua:71: attempt to index local 'httpRequest' (a nil value) (/home/jacobkeeler/sdl_atf/src/remote_adapter/remote_adapter_client/lua_remote_library.cc:16)
SCRIPT STATUS: ABORTED
'smartDeviceLinkCore' is running, PID: 1374830, terminating ...
Done

@ShobhitAd
Copy link
Contributor Author

Seems that the HTTP header is only added to the binary data in PROPRIETARY mode https://github.com/smartdevicelink/sdl_core/blob/master/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/mobile/on_system_request_notification.cc#L127.

When the HTTP header is added by the sample_policy_manager for EXTERNAL_PROPRIETARY, it modifies the snapshot file directly https://github.com/smartdevicelink/sdl_core/blob/master/src/appMain/sample_policy_manager.py#L65. I've limited the test to PROPRIETARY policies

@ShobhitAd ShobhitAd merged commit f39e49c into develop May 27, 2022
@ShobhitAd ShobhitAd deleted the defects/3912 branch May 27, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants