Add scripts for core issue #2468 #2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShobhitAd
requested changes
Aug 23, 2022
There was a problem hiding this comment.
I think these tests might be a lot shorter if we add a common file since most of the request param values are the same for each script and we could have a common AddCommand(pParams, expectecUIResult, expectedVRResult) function - the expectations would have to be based around the expectedUIResult and expectedVRResult
| @@ -0,0 +1,141 @@ | |||
| --------------------------------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
Suggested change
| --------------------------------------------------------------------------------------------------- | |
| -------------------------------------------------------------------------------------------------- | |
| -- Issue: https://github.com/smartdevicelink/sdl_core/issues/2468 | |
| --------------------------------------------------------------------------------------------------- |
Just to stay consistent with the other defect tests
| -- [AddCommand] GENERIC_ERROR: getting GENERIC_ERROR on UI.AddCommand timeout | ||
| -- | ||
| -- Description: | ||
| -- Mobile application sends valid AddCommand request with both "vrCommands"and "menuParams" |
There was a problem hiding this comment.
Suggested change
| -- Mobile application sends valid AddCommand request with both "vrCommands"and "menuParams" | |
| -- Mobile application sends valid AddCommand request with both "vrCommands" and "menuParams" |
| -- b. appID is registered and activated on SDL | ||
|
|
||
| -- Steps: | ||
| -- 1. appID requests AddCommand with both vrCommands and menuParams |
There was a problem hiding this comment.
Suggested change
| -- 1. appID requests AddCommand with both vrCommands and menuParams | |
| -- 1. App requests AddCommand with both vrCommands and menuParams |
|
|
||
| -- Pre-conditions: | ||
| -- a. HMI and SDL are started | ||
| -- b. appID is registered and activated on SDL |
There was a problem hiding this comment.
Suggested change
| -- b. appID is registered and activated on SDL | |
| -- b. App is registered and activated on SDL |
| } | ||
| } | ||
|
|
||
| local responseUiParams = { |
There was a problem hiding this comment.
Should this be renamed to
Suggested change
| local responseUiParams = { | |
| local requestUiParams = { |
given that its used with ExpectRequest
There was a problem hiding this comment.
This comment applies to all other scripts (with UI.AddCommand) as well
|
|
||
| -- Pre-conditions: | ||
| -- a. HMI and SDL are started | ||
| -- b. appID is registered and activated on SDL |
There was a problem hiding this comment.
Suggested change
| -- b. appID is registered and activated on SDL | |
| -- b. App is registered and activated on SDL |
| -- b. appID is registered and activated on SDL | ||
|
|
||
| -- Steps: | ||
| -- 1. appID requests AddCommand with vrCommands |
There was a problem hiding this comment.
Suggested change
| -- 1. appID requests AddCommand with vrCommands | |
| -- 1. App requests AddCommand with vrCommands |
| @@ -0,0 +1,123 @@ | |||
| --------------------------------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
Suggested change
| --------------------------------------------------------------------------------------------------- | |
| -------------------------------------------------------------------------------------------------- | |
| -- Issue: https://github.com/smartdevicelink/sdl_core/issues/2468 | |
| --------------------------------------------------------------------------------------------------- |
|
|
||
| -- Pre-conditions: | ||
| -- a. HMI and SDL are started | ||
| -- b. appID is registered and activated on SDL |
There was a problem hiding this comment.
Suggested change
| -- b. appID is registered and activated on SDL | |
| -- b. App is registered and activated on SDL |
| -- b. appID is registered and activated on SDL | ||
|
|
||
| -- Steps: | ||
| -- 1. appID requests AddCommand with vrCommands |
There was a problem hiding this comment.
Suggested change
| -- 1. appID requests AddCommand with vrCommands | |
| -- 1. App requests AddCommand with vrCommands |
ShobhitAd
requested changes
Aug 24, 2022
| @@ -0,0 +1,209 @@ | |||
| local common = require('test_scripts/Smoke/commonSmoke') | |||
There was a problem hiding this comment.
Suggested change
| local common = require('test_scripts/Smoke/commonSmoke') | |
| --------------------------------------------------------------------------------------------------- | |
| -- Common module | |
| --------------------------------------------------------------------------------------------------- | |
| --[[ Required Shared libraries ]] | |
| local common = require('test_scripts/Smoke/commonSmoke') |
Just for consistency
ShobhitAd
approved these changes
Aug 24, 2022
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATF Test Scripts to check smartdevicelink/sdl_core#2468
This PR is ready for review.
Summary
Adds tests which check behavior when AddCommand times out (DeleteCommand should be sent for any pending or successful requests)
ATF version
develop
Changelog
Bug Fixes
CLA