ResetGlobalProperties does't reset HELPPROMPT and VRHELPITEMS to default values

[AStasiuk]

Occurrence:

Always

Preconditions:

Delete app_info.dat file.
SDL started. Application is registered and activated on HMI.

Steps to reproduce:

1. Send SetGlobalProperties from mobile (helpPrompt, timeoutPrompt, vrHelpTitle, vrHelp). ==>successfully set
2. Stop smartDeviceLinkCore in terminal (through ctrl+c) and do not exit from mobile app.
3. Start smartDeviceLinkCore and HMI.
4. Mobile App is registered and activated (HMI lvl FULL)
5. Send SetGlobalProperties from mobile (helpPrompt, timeoutPrompt, vrHelpTitle, vrHelp). ==>successfully set
6. Send ResetGlobalProperties from mobile (helpPrompt, timeoutPrompt, vrHelpTitle, vrHelp)

Expected result:

SDL should send to HMI UI.SetGlobalProperties("vrHelpTitle", "vrHelp") with default values.
SDL should send to HMI TTS.SetGlobalProperties with "helpPrompt" parameter that should be reset to default value (smartDeviceLink.ini file contains default values for "helpPrompt"

Actual result:

SDL sends to HMI UI.SetGlobalProperties(vrHelpTitle) without vrHelp - not OK
SDL sends to HMI TTS.SetGlobalProperties("helpPrompt":[ ]) - empty array - not OK.

Environment:

branch: release candidate SDL_RB_B3.10 (87259f8)
App: any
SPT cw 41 ver:2.1.60
Transport: any
OS: XUbuntu 12.04
HMI: HTML5

Expected delivery:

Source code updates
Code comments
UTs add/update
ATF tests add/update
Add/update CI plans/jobs
SDD updates
Guidelines update (sdl_core_guides)
Guidelines update (sdl_hmi_integration_guidelines)

[Jack-Byrne]

@AStasiuk Can you add the related milestone for this issue? I am not sure if it is policies related or remote control. The branch you have listed is an app link branch

[Itileda]

@JackLivio This SDL issue was reported in scope of smoke testing on release candidate 4.4.0 with REMOTE_CONTROL functionality. Issue is not related to RC.

[LitvinenkoIra]

Significant loss of functionality on HMI side with standard use-case:
During ResetGlobalProperties all parameters (vrHelpTitle, helpPromt) should be processed by SDL properly.

[HSavynetska]

Environment:
Script: smartdevicelink/sdl_atf_test_scripts#1931
SDL build: develop branch (ba1da7b)
ATF: develop branch

Status: defect is reproduced.

[ghost]

The next pull request provided bug fixing of this issue:
PR #2337

[jacobkeeler]

Note that this will potentially affect behavior in the implementation of #2154 in the case where all existing commands have been deleted, vr_help and help_prompt will need to be reset.

[jacobkeeler]

I think based on the description in the Mobile API:

Resetting means, that they have the same value as at start up (default)

Means that either these default values should be defined by the HMI, or they should be sent by Core at some point automatically. This means if these INI values are being used, these defaults should be used upon registration, not just used when an app sends ResetGlobalProperties.

[E-SAITO-TMC]

@joeygrover -san
A fix has been proposed for this issue. Is the review of a fix finished? If so, when will it be merged? For the next HU development of TOYOTA, it is necessary to improve the quality of SDLCore, so we believe it is necessary to modify this issue.

[theresalech]

Hi @E-SAITO-TMC, contents for SDL releases are determined by the Steering Committee, and the Project Maintainer works on features and bug fixes raised as high priority by Steering Committee representatives. This particular issue has not yet been raised as high priority. However, if Toyota would like to see this fix in the next release of SDL Core (planned for October 28, 2020), we can make note of such.

Please confirm if this is priority for Toyota. If so, we will include this issue in our proposed release contents, which will be presented to the Steering Committee and voted upon/finalized in June. Thank you!

[E-SAITO-TMC]

@theresalech -san Thank you for your comment. This issue is medium-priority for Toyota.

[theresalech]

@E-SAITO-TMC, thank you. We have documented that this is medium priority for Toyota, and will include for Steering Committee review and vote when planning the contents for the Q4 Core release. This planning will take place in June.

[iCollin]

Closed via #3357