Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL does not validate invalid characters in HMI requests. #1862

Closed
GetmanetsIrina opened this issue Nov 20, 2017 · 5 comments
Closed

SDL does not validate invalid characters in HMI requests. #1862

GetmanetsIrina opened this issue Nov 20, 2017 · 5 comments
Labels

Comments

@GetmanetsIrina
Copy link

GetmanetsIrina commented Nov 20, 2017

Bug Report

SDL does not validate invalid characters (\n, \t, only whitespace ) in string parameters in HMI requests.

Steps
  1. HMI sends SDL.GetUserFriendlyMessage request with invalid characters
Expected Behavior

SDL responds with code INVALID_DATA to HMI.

Observed Behavior

SDL responds with code:0 (SUCCESS) to HMI.

OS & Version Information
  • OS/Version: Ubuntu 16.04
  • SDL Core Version: 4eb09bf
  • Testing Against: ATF
Test Case, Sample Code, and / or Example App
@aderiabin
Copy link

Contributor priority is set Medium with reason: The issue is related to functionality: existence of response from HMI/SDL

@HSavynetska
Copy link

Environment:
Script: smartdevicelink/sdl_atf_test_scripts#1949
SDL build: develop branch (621080d)
ATF: develop branch

Status: defect is reproduced.

@ghost
Copy link

ghost commented Jul 31, 2018

The next PR provided fix this issue: Pull request

@VjKlepikov
Copy link

The issue is relevant on the current develop branch

Environment:
Test script: smartdevicelink/sdl_atf_test_scripts#1949
SDL build: https://github.com/smartdevicelink/sdl_core/tree/develop ( 891497b )
ATF: develop branch

@iCollin iCollin mentioned this issue May 14, 2020
1 task
@iCollin
Copy link
Collaborator

iCollin commented May 20, 2020

Closed via #3369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants