ChoiceSet being processed in DeleteInteractionChoceSet

[LitvinenkoIra]

Occurrence: Always

Description

ChoiceSet being processed in DeleteInteractionChoceSet

Preconditions

• SDL and HMI are started.
• App is registered and activated.

Steps to reproduce

1. HMI processes VR.DeleteCommands_request related to choiceSetID_1 AND app sends PerformInteractionChoiceSet with choiceSetID_1

Actual result

SDL responds INVALID_ID (success:false) to this PerfromInteraction

Expected result

SDL must respond REJECTED (success:false) to this PerfromInteraction

Environment

Attachments

Expected delivery

• Source code updates
• Code comments
• UTs add/update (not required)
• ATF tests add/update
• Manual tests (not required)
• Add/update CI plans/jobs (not required)
• SDD updates (not required)
• Guidelines update (sdl_core_guides) (not required)
• Guidelines update (sdl_hmi_integration_guidelines) (not required)

[aderiabin]

Contributor priority is set Medium with reason: The issue is related to Perform interaction RPC functionality. Supposed that SDL responds with wrong result code.

[dboltovskyi]

Issue is still applicable for https://github.com/smartdevicelink/sdl_core/tree/release/8.0.0 (de58a41)

[theresalech]

@dboltovskyi, can you please advise when merge conflicts for PR #2613 have been resolved and the PR is ready for Livio's review?

[dboltovskyi]

@theresalech Please notice initial fix for this issue in #2613 is pretty old. We're updating and re-testing it now. Our plan is to re-submit new version in a couple of days.

[iCollin]

Hello @dboltovskyi, could you please help me understand what this change would be used for? What would Mobile do differently if it receives a REJECTED responses versus the current INVALID_ID? From a quick look, I don't see the value of differentiating these pending delete choice sets.

[dboltovskyi]

@VjKlepikov Could you please support with the question from @iCollin. Thank you.

[VjKlepikov]

@iCollin According to requirements APPLINK-14954

In case HMI processes VR.DeleteCommands_request related to choiceSetID_1 AND app sends PerformInteractionChoiceSet with choiceSetID_1 -> SDL must respond REJECTED (success:false) to this PerfromInteraction

Also, I believe the mobile does not send another PerformInteractionChoiceSet with the same ID in case it receives "INVALID_ID"
If the "REJECTED" would be the response in which tells the mobile app it should maybe try the request again with the same ID because DeleteInteractionChoceSet could be rejected

[iCollin]

@VjKlepikov thank you for your explanation.

I understand there is a requirement but I am not sure it is still applicable considering Core has unconditionally replied success for DeleteInteractionChoiceSet until recently. It looks like the libraries do not currently consider the response code to retry a PerformInteraction.

I agree it is possible mobile could retry if it gets REJECTED response, but when would the second PerformInteraction request succeed? The SDL HMI sends success unless the choice set is in use, but an in use check already exists in Core. I can't really imagine a use case where a second PerformInteraction request would succeed.

I am still struggling to understand the value of tracking if a choice set is pending delete. Do my concerns make sense to you?

[VjKlepikov]

@iCollin
I believe that the second PerformInteraction request would succeed in case HMI does not respond to VR.DeleteCommand triggered by DeleteInteractionChoiceSet during first request. I agree that the libraries do not currently consider the response code to retry a PerformInteraction but it can be changed by mobile developers

[iCollin]

Closed via #3826