Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDL 0189] Restructuring OnResetTimeout #2422

Closed
theresalech opened this issue Jul 26, 2018 · 2 comments
Closed

[SDL 0189] Restructuring OnResetTimeout #2422

theresalech opened this issue Jul 26, 2018 · 2 comments
Labels
proposal Accepted SDL Evolution Proposal

Comments

@theresalech
Copy link
Contributor

theresalech commented Jul 26, 2018

Proposal: Restructuring OnResetTimeout

This proposal is to use OnResetTimeout for applicable interfaces so as to update the function and expand it to be used by a broader set of RPCs than just in UI and TTS interfaces.

Review: smartdevicelink/sdl_evolution#556

Steering Committee Decision:

The Steering Committee voted to accept this proposal with the following revisions: extensionPeriod will be renamed to resetPeriod and the proposal will address that HMI Integration Guidelines will need to be updated to call out that there is not currently version negotiation between HMI and Core, so older HMI implementations will not work with this new version of Core.
Lastly, it was noted that details of deprecating an HMI API will be determined upon implementation.

The proposal .md file was updated to reflect these revisions on 7/26/18.

@theresalech
Copy link
Contributor Author

Proposal has been revised:

  • To remove UI/TTS OnResetTimeout from HMI_API as it has already been noted that older HMI implementations would not work with this change.
  • To remove range from requestID param so that it conforms to range for unsigned 32bit signed Integer.
  • To add greater clarification on the change that will be made to the HMI API, noting that it would be a major version change not only to HMI but to core as well. Additionally, the current logic presented in the accepted proposal can stay intact until a major version change.

Steering Committee Discussion:

There was much discussion on whether or not breaking changes in the HMI directly impact core’s versioning. It was determined that we must update Core’s version based on updates to the HMI_API version. If there is a breaking change made in either the HMI or in the MOBILE API then the core versioning will need to be updated to align, this will be precedent moving forward.

Steering Committee Review

@ShobhitAd
Copy link
Contributor

Closed via #3726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Accepted SDL Evolution Proposal
Projects
None yet
Development

No branches or pull requests

2 participants