DeadLock in TranpsortManager during transport disconnect

[GetmanetsIrina]

Bug Report

Once DeadLock in TranpsortManager during transport disconnect

Occurrences

1/100

Reproduction Steps

1. HMI and SDL are started
2. ~3 Mobile app is registered
3. Perform transport disconnect

Expected Behavior

SDL continues work without deadlock

Observed Behavior

DeadLock occurs in TransportManager. It's unable to connect the device and SDL does not process the messages from HMI.

TRACE [13 Apr 2020 11:28:51,937][0x7ff243422700][TransportManager] /home/developer/sdl/repo/SDLMirror/sdl_core/src/components/transport_manager/src/transport_manager_impl.cc:1084 TransportManagerImpl::Handle: enter
DEBUG [13 Apr 2020 11:28:51,937][0x7ff243422700][TransportManager] /home/developer/sdl/repo/SDLMirror/sdl_core/src/components/transport_manager/src/transport_manager_impl.cc:1341 TransportManagerImpl::Handle: Event ON_RECEIVED_FAIL
DEBUG [13 Apr 2020 11:28:51,937][0x7ff243422700][TransportManager] /home/developer/sdl/repo/SDLMirror/sdl_core/src/components/transport_manager/src/transport_manager_impl.cc:1356 TransportManagerImpl::Handle: event_type = ON_RECEIVED_FAIL
TRACE [13 Apr 2020 11:28:51,937][0x7ff243422700][TransportManager] /home/developer/sdl/repo/SDLMirror/sdl_core/src/components/transport_manager/src/transport_manager_impl.cc:1391 TransportManagerImpl::Handle: exit
TRACE [13 Apr 2020 11:28:51,937][0x7ff243422700][TransportManager] /home/developer/sdl/repo/SDLMirror/sdl_core/src/components/transport_manager/src/transport_manager_impl.cc:1084 TransportManagerImpl::Handle: enter
TRACE [13 Apr 2020 11:28:51,938][0x7ff243c23700][TransportManager] /home/developer/sdl/repo/SDLMirror/sdl_core/src/components/transport_manager/src/transport_manager_impl.cc:1401 TransportManagerImpl::Handle: enter
DEBUG [13 Apr 2020 11:28:51,938][0x7ff243c23700][TransportManager] /home/developer/sdl/repo/SDLMirror/sdl_core/src/components/transport_manager/src/transport_manager_impl.cc:1424 TransportManagerImpl::Handle: Got adapter 0x5615372938a0[0] by session id 36
ERROR [13 Apr 2020 11:28:51,938][0x7ff243c23700][TransportManager] /home/developer/sdl/repo/SDLMirror/sdl_core/src/components/transport_manager/src/transport_manager_impl.cc:1438 TransportManagerImpl::Handle: Data sent error
TRACE [13 Apr 2020 11:28:51,938][0x7ff243c23700][TransportManager] /home/developer/sdl/repo/SDLMirror/sdl_core/src/components/transport_manager/src/transport_manager_impl.cc:1444 TransportManagerImpl::Handle: exit

Note:

1. It is unable to reproduce issue on previous release because of SDL Core crash after quickly and repeatedly connect/disconnect USB cable #3149, but according to code analysis this is not regression issue and presents on previous releases.
2. The issue can be reproduced more often after fixing of Deadlock during transport re-connect via USB #3323

OS & Version Information

• sdl_hmi branch: develop
• commit: e8baa2d8f3f4b43d261323e0dd2c30843509e925
• sdl_core branch: https://github.com/smartdevicelink/sdl_core/tree/6.1.0_RC
• transport: USB

Logs

SmartDeviceLinkCore.zip
SmartDeviceLinkCore_deadlock.zip

[GetmanetsIrina]

Issues is reproduced on release_6.1_RC_2, issues has occurrences 1/100.

[AKalinich-Luxoft]

@theresalech PR with fix is ready for Livio review.

[theresalech]

Hi @AKalinich-Luxoft, this issue is not currently planned for the Core 6.2 release, but we will work to include if time allows.

[jacobkeeler]

Closing with the merge of #3347