Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDL 0308] Add a Reason Parameter to All Protocol NAKs #3434

Closed
theresalech opened this issue Jun 11, 2020 · 1 comment
Closed

[SDL 0308] Add a Reason Parameter to All Protocol NAKs #3434

theresalech opened this issue Jun 11, 2020 · 1 comment
Labels
proposal Accepted SDL Evolution Proposal

Comments

@theresalech
Copy link
Contributor

Proposal: Add a Reason Parameter to All Protocol NAKs

As a maintainer of an app library, it is often difficult to understand why Core has NAKed a protocol message. Most NAKs currently have a rejectedParams parameter, but in practice, this has not been enough information to determine why a NAK has occurred and properly alert the developer. In place of the rejectedParams parameter, the RegisterSecondaryTransportNAK has a reason parameter to describe the failure reason. This is a better approach and we should expand it to all NAK parameters.

Review: smartdevicelink/sdl_evolution#1027

@ShobhitAd
Copy link
Contributor

Closed via #3462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Accepted SDL Evolution Proposal
Projects
None yet
Development

No branches or pull requests

2 participants