SDL doesn't provide individual VD result code for clusterModeStatus in SubscribeVehicleData/UnsunscribeVehicleData responses from HMI

[dboltovskyi]

Bug Report

SDL doesn't provide individual VD result code for clusterModeStatus in SubscribeVehicleData/UnsunscribeVehicleData responses from HMI in case of 2 apps.

Reproduction Steps

Preconditions:

1. SDL and HMI are started
2. SubscribeVehicleData RPC and <vd_param> parameter are allowed by policies
3. App_1 and App_2 are registered
4. App_1 successfully subscribes to <vd_param>

In case:

1. App_2 sends valid SubscribeVehicleData(<vd_param>=true) request to SDL

Expected Behavior

SDL does:

• send SubscribeVehicleData response with (success = true, resultCode = "SUCCESS", <vd_param> = <data received from HMI>) to App_2
• not transfer this request to HMI

Observed Behavior

SDL does:

• not send <vd_param> = <data received from HMI>) in response to App_2

OS & Version Information

• OS/Version: Ubuntu 18.04
• SDL Core Version: https://github.com/smartdevicelink/sdl_core/tree/develop (81fb32e)
• Testing Against: ATF

Test Case, Sample Code, and / or Example App

• ATF and SDL logs: 2020-07-15_13-31-09_3460.tar.gz

[dboltovskyi]

Please take into account that for SubscribeVehicleData/UnsunscribeVehicleData real VD parameter name is clusterModes instead of clusterModeStatus
This discrepancy was described in issue #1696

[theresalech]

@dboltovskyi can you please advise if Luxoft is planning to submit a PR to resolve this issue? Thank you!

[dboltovskyi]

@theresalech Yes, Luxoft team is planning to submit a fix for this issue.

[ShobhitAd]

Closed via #3830

[VjKlepikov]

The issue is reproduced on the current develop branch 8f1ccb2 for new scripts PR 2618
Logs: 2022-01-17_08-33-54.236_failed.tar.gz

Please notice Luxoft team is going to prepare a fix.

[jacobkeeler]

@VjKlepikov It looks like the failure in smartdevicelink/sdl_atf_test_scripts#2618 is slightly different than the described issue, but similar.

In this case, if the app requests clusterModeStatus in SubscribeVehicleData (along with other parameters) when it does not have permissions for clusterModeStatus.
Core should send clusterModes in the response with the DISALLOWED result code, but instead it omits the clusterModes parameter.

[ShobhitAd]

Closed via #3847