Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL doesn't ignore value of 'frameInfo' field for 'Single' and 'First' frames #3717

Closed
dboltovskyi opened this issue Jun 9, 2021 · 4 comments
Assignees
Labels

Comments

@dboltovskyi
Copy link
Contributor

dboltovskyi commented Jun 9, 2021

Bug Report

SDL doesn't ignore value of 'frameInfo' field for 'Single' and 'First' frames.
It has to do so according to current protocol specification: 2.3 Frame Header Fields ("Frame Info")

Reproduction Steps
  1. App registered
  2. App sends PutFile data
    a) as a single frame
    b) as a multi frame
  3. Make sure App sends non-zero value in 'frameInfo' field of 'Single' and 'First' frames
Expected Behavior

SDL does:

  • ignore value of 'frameInfo' field for 'Single' and 'First' frames
  • proceed with PutFile successfully
Observed Behavior

SDL fails to proceed the frames with message in log:

IncomingDataHandler::CreateFrame: Packet validation failed
OS & Version Information
Test Case, Sample Code, and / or Example App
@dboltovskyi
Copy link
Contributor Author

Issue is raised based on comment: smartdevicelink/sdl_evolution#1070 (comment)
Luxoft team is going to provide a fix.

@jordynmackool
Copy link

Hi @dboltovskyi, Livio is going to begin Release candidate prep, starting on 2021-08-30 for the upcoming Core 8.0 release. As noted in your comment above, Luxoft is planning on contributing a PR for this issue. Can you please provide timing on when Luxoft will have this PR ready for Livio review? Thanks!

@dboltovskyi
Copy link
Contributor Author

@jordynmackool Please notice both PRs related to this issue are ready for PM review.

@iCollin
Copy link
Collaborator

iCollin commented Aug 24, 2021

Closed via #3762

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants