Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core assumes application will remain valid thru registration process #3813

Closed
iCollin opened this issue Nov 3, 2021 · 1 comment
Closed
Labels

Comments

@iCollin
Copy link
Collaborator

iCollin commented Nov 3, 2021

Bug Report

It was noticed that Core assumes applications_ entry will be valid throughout the registration process, when the applications_ entry may be removed.

Reproduction Steps
  1. Register some apps
  2. Change language quickly
Expected Behavior

Registration process completes successfully

Observed Behavior

application == nullptr in either of the following methods: (depending on timing)

commands::RegisterAppInterfaceRequest::CheckLanguage()
sdl_rpc_plugin::commands::FinishSendingResponseToMobile(...)
OS & Version Information
@iCollin
Copy link
Collaborator Author

iCollin commented Nov 23, 2021

Closed via #3815

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants