SDL removes the current "consumer_friendly_messages" section in Local PT in case the Updated PT omits "consumer_friendly_messages" section

[VjKlepikov]

Bug Report

SDL removes the current "consumer_friendly_messages" section in Local PT in case the Updated PT omits "consumer_friendly_messages" section

Reproduction Steps

1. Make sure SDL is built with HTTP flow
2. Register new application => PTU is triggered
3. PTU omits "consumer_friendly_messages" section

Expected Behavior

SDL maintains the current "consumer_friendly_messages" section in Local PT

Observed Behavior

SDL removes the current "consumer_friendly_messages" section in Local PT in case the Updated PT omits "consumer_friendly_messages" section

OS & Version Information

• OS/Version: Ubuntu 18
• SDL Core Version: https://github.com/smartdevicelink/sdl_core/tree/develop (6ca6961)

Test Case, Sample Code, and / or Example App

• Tests scripts: *./test_scripts/Policies/build_options/070_ATF_PTU_Merge_Into_Local_PT_ConsumerFriendlyMessages_Omitted_HTTP.lua

Logs: Logs.zip

[VjKlepikov]

Please notice this is a regression issue that became reproducible after merge of #3842
@theresalech Can you please advise if the Livio team is planning on submitting a PR to fix?

[theresalech]

@VjKlepikov our team will review the issue and advise.

[jacobkeeler]

@VjKlepikov can you confirm if this issue only occurs in HTTP mode?

[jacobkeeler]

After testing, it appears that this issue is reproducible in master if OnDriverDistraction(DD_ON) is sent prior to registering the app. It seems likely that the issue lies in this section of code

[jacobkeeler]

closed via #3852