Complement checks that consider HMI response to be invalid #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review: @indlu, @VVeremjova, @LitvinenkoIra, @LuxoftAKutsan |
VVeremjova
suggested changes
May 15, 2017
| "HMI response contains unrecognizable result code, so it is " | ||
| "considered as invalid response"); | ||
| response[strings::msg_params][strings::result_code] = | ||
| hmi_apis::Common_Result::GENERIC_ERROR; |
There was a problem hiding this comment.
@dcherniev You send message to mobile, but send code from hmi_apis.
There was a problem hiding this comment.
@VVeremjova You right, fixed in 2834639.
added 2 commits
May 17, 2017 16:09
Added additional check for one of the cases which should consider received HMI response as invalid response.
Changed few expectations in unit tests from INVALID_ENUM into GENERIC_ERROR.
dcherniev
force-pushed
the
fix/complement_checks_that_consider_hmi_response_to_be_invalid
branch
from
f6b464e
to
c8d2be3
Compare
LuxoftAKutsan
approved these changes
May 18, 2017
VVeremjova
approved these changes
May 18, 2017
LitvinenkoIra
approved these changes
May 18, 2017
1 task
|
Closed in favor of #3718 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added additional check for one of the cases which should consider received HMI response as invalid response.