do not set language and hmiDisplayLanguage in RAI response when these are not valid #2231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… UI active lauguage is not valid
|
Can one of the admins verify this patch? |
|
Closed in favor of #3435 as edited file no longer exists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2230
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
I tested this fix in our internal devboard HU and testing iOS SDL app.
Summary
Do not set language and hmiDisplayLanguage in RAI response when these are not valid instead of being set to -1. -1 is the raw value of INVALID_ENUM.
SDL iOS proxy expects string value for language, therefore crash may occur when it receives integer value (-1).
Changelog
Bug Fixes
CLA