Set initialize state for the Integer type #2548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default constructor of Interger class assigns the min value for the wrapped variable, hoowever it keeps the initialize state us `Uninitialized`. So in case when latter user apply such operations as `++`, `+=` the value will be changed but the state is not. The commit adds ability to change initialize state for the class after mentioned operations. So user does not have to call additionaly `initialize` method.
ZhdanovP
requested review from
AByzhynar,
AKalinich-Luxoft,
KVGrygoriev,
LuxoftAKutsan,
IGapchuk,
Itileda,
mked-luxoft and
Ypostolov
AKalinich-Luxoft
approved these changes
Aug 31, 2018
KVGrygoriev
approved these changes
Aug 31, 2018
IGapchuk
approved these changes
Sep 4, 2018
LuxoftAKutsan
approved these changes
Sep 6, 2018
AByzhynar
approved these changes
Oct 9, 2018
|
@ZhdanovP Typo in branch name, commit and PR description. Check & correct |
ghost
approved these changes
Nov 29, 2018
IPolozov-luxoft
approved these changes
Nov 29, 2018
jacobkeeler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2440
This PR is ready for review.
Risk
This PR makes no API changes.
Summary
The default constructor of Interger class assigns the min value
for the wrapped variable, hoowever it keeps the initialize state us
Uninitialized. So in case when latter user apply such operations as++,+=the value will be changed but the state is not.The commit adds ability to change initialize state for the class
after mentioned operations. So user does not have to call additionaly
initializemethod.CLA