Remove some unused methods from MediaManager #2774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SKobziev
requested review from
LuxoftAKutsan,
AByzhynar,
AKalinich-Luxoft,
mked-luxoft,
LitvinenkoIra and
ZhdanovP
1 task
LitvinenkoIra
approved these changes
Dec 4, 2018
ZhdanovP
approved these changes
Jan 17, 2019
mked-luxoft
approved these changes
Jan 17, 2019
jacobkeeler
changed the title
jacobkeeler
requested changes
Apr 15, 2021
| @@ -40,9 +40,6 @@ namespace media_manager { | |||
|
|
|||
| class MediaManager { | |||
| public: | |||
| virtual void PlayA2DPSource(int32_t application_key) = 0; | |||
| virtual void StopA2DPSource(int32_t application_key) = 0; | |||
|
|
|||
There was a problem hiding this comment.
Deprecate instead of remove, we need to wait for a major release to remove public methods
There was a problem hiding this comment.
@jacobkeeler the following changes were done:
- Merge latest develop branch in 40c3b87
- Reverted changes related to this PR in 7cf8f53
- Mark redundant code as deprecated in 07d5fe0
Not sure if I need to remove related unit tests for now or should they be removed together with deprecated functions
There was a problem hiding this comment.
@AKalinich-Luxoft I think that the associated tests can be removed
There was a problem hiding this comment.
@jacobkeeler removed in c1d69b6
…functionality_from_MediaManager
This reverts commit bc0d62c.
jacobkeeler
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2450
This PR is [ready] for review.
Risk
This PR makes [no ] API changes.
Summary
There are some unused methods in base class MediaManager which are redefined in MediaManagerImpl. These methods(PlayA2DPSource, StopA2DPSource) aren't used in any place. Based on this, the methods were removed
Copy of #2681
CLA