Release 6.0.0 #3100
Merged
Release 6.0.0 #3100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add check for missing option parameter `menu_icon`
RPC Passing Handler unit tests
# Conflicts: # src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/rc_command_factory.cc # src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/mobile_command_factory.cc # src/components/transport_manager/src/cloud/cloud_websocket_transport_adapter.cc # src/components/transport_manager/test/include/transport_manager/cloud/sample_websocket_server.h # src/components/transport_manager/test/sample_websocket_server.cc # src/components/transport_manager/test/transport_adapter_test.cc # src/components/transport_manager/test/websocket_connection_test.cc
Add unit tests for icon_url
…service_data_image
SDL remote control shall allow a mobile application to know which HD sub-channel index has a signal, so that the app can tune the HD radio to that sub-channel successfully. According to this motivation, "availableHDs" parameter of RadioControlData structure marks as deprecated since 5.1 API version and add new parameter "availableHdChannels" that is a collection of available HD radio channels. This parameter will be available since 5.1 API version. Also "availableHDsAvailable" parameter of RadioControlCapabilities structure marks as deprecated since 5.1 API version and add new parameter "availableHdChannelsAvailable" that will be available since 5.1 API version. SDL remote control shall allow a mobile application to turn the climate control on or off if the vehicle supports it. According to this motivation, "climateEnable" parameter add to ClimateControlData structure. Also "climateEnableAvailable" parameter add to ClimateControlCapabilities structure.
Update API's version
…ce_data_image Add Parameter Media Service Data mediaImage
…ature/update_and_unpublish_app_service
Also fix style
The filter created to manage data in terms of SisData->StationLocation->GPSData, since GPSData should not contain more params then latitude, longitude, altitude
…nclude/rc_rpc_plugin/rc_helpers.h Fix typo Update src/components/interfaces/MOBILE_API.xml Co-Authored-By: Shobhit Adlakha <ShobhitAd@users.noreply.github.com>
* Add select function to pipe write call * Address dropping frames comment * Use temp var for write result
) * Fix SDL timeout logic for RPCs with own timer SDL must send GENERIC_ERROR to app in case HMI does NOT respond during <DefaultTimeout>+<RPCs_internal_timeout> for all RPCs with own timer * Fix default timeout for HMI requests For RPS with own timers SDL should apply default+internal timeout for mobile and HMI requests
…_spec (#3085) * Resolve conflicts between the MOBILE_API in Core versus the official rpc_spec * Remove Ford references * Rearrange response parameters to be consistent * Fix SystemCapabilityType order in HMI API
This is an issue specific for EXTERNAL_PROPRIETARY flow only. This issue is exposed by PolicyHandlerTest unit test: ResetPolicyTable_WithPreloadedFile_ExpectPolicyTableReset which sometimes is failing. The main problem was that database reset(drop) and backup can be done simultaneously in different threads which were not synchronized. In that case, database drop often may be failed because another thread is trying to write something into the DB table which is going to be dropped. This causes above unit test to fail sometimes. To make that unit test and policy component more stable, these two threads were synchronized by additing a waiting function, so one thread will be able to wait for another thread to finish its own staff.
* Fix revoked VD items subscription after PTU There was found an issue that SDL still kept subscriptions for custom vehicle data items even for case when they were removed during PTU. By that reason, SDL was crashing with DCHECK on attempt to unsubscribe from non existing custom data. There was added missing logic of internal unsubscribe in case some custom vehicle data was removed by policies. * Fix sending of UnsubscribeVehicleData Was added a missing part of logic of subscriptions control - cache manager was updated to keep the vehicle data which was removed by last PTU. Custom vehicle data manager was updated to consider the removed vehicle data and also prepare and send unsubscribe requests to HMI for case when some vehicle data was removed and some application was subscribed on it. * fixup! Fix sending of UnsubscribeVehicleData * fixup! Fix sending of UnsubscribeVehicleData * fixup! Fix sending of UnsubscribeVehicleData * fixup! Fix sending of UnsubscribeVehicleData
There was found one corner case when SDL does not change the internal status when service start was refused due to current HMI level of application. Was added missing check to set status properly and send expected notification.
…tartService (#3082) * Fix HMI level on StartServiceNAck * fixup! Fix HMI level on StartServiceNAck
…pyrights Update copyrights for generated files
* Fix log severity level in on_vehicle_data_notification.cc Fixed log severity level in on_vehicle_data_notification.cc: LOG4CXX_ERROR is changed on LOG4CXX_DEBUG and corrected a mistake in string. * Resolve merge conflict * Fix Connection Typo * Revert disabled unit test
…_array_key_translation Fix custom VD key translation for struct arrays
…kup_and_reset_functions_in_cache Synchronize backup and reset policy functions
…imits Fix custom vehicle data limits
…#2778) * Provide operation result to function file_system::CreateDirectory The function CreateDirectory signature (return value) was changed in file_system.h * Added const cv for the creating directory path into unit tests(when uses file_system::CreateDirectory) * Fix merge conflict
* Add unit tests * Fix subscription to app services * fixup! Fix subscription to app services * fixup! Add unit tests * fixup! Add unit tests * fixup! Fix subscription to app services * fixup! Fix subscription to app services * fixup! Add unit tests * fixup! Add unit tests * fixup! Add unit tests
Jack-Byrne
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release 6.0.0
Supported Specifications
Completed Features
[SDL 0173] Read Generic Network Signal Data
[SDL 0211] Service Status Update to HMI
[SDL 0207] RPC message protection
[SDL 0216] Widget support
[SDL 0138] Make 'audioPassThruCapabilities' of HMI an array
[SDL 0179] Pixel density and Scale
[SDL 0221] Remote Control - Allow Multiple Modules per Module Type
[SDL 0184] Cancel Interaction RPC
[SDL 0204] Support running the same app from multiple devices at the same time
[SDL 0231] Add Tiles as an Option for Main Menus
[SDL 0186] Template Titles
[SDL 0177] Alert icon
[SDL 0116] Open Menu RPC
[SDL 0225] Update Published App Services
[SDL 0108] AutoCompleteList
[SDL 0224] Navigation Subscription Buttons
[SDL 0119] SDL Passenger Mode
[SDL 0223] Add Currently Playing Media Image to MediaServiceData
[SDL 0115] CloseApplication RPC
[SDL 0213] Remote Control - Radio and Climate Parameter Update
[SDL 0199] Adding-GPS-Shift-support
[SDL 0212] Add Ability to Reuse a SyncFileName for a PutFile
[SDL 0246] Add App Services to HMICapabilities
Completed Bug Fixes/Enhancements
Fix/Set mandatory=false for optional response params
DialNumber: Update HMI API description to match Mobile API description
EmergencyEvent->maximumChangeVelocity data type is incorrect in HMI API
SDL crashes while sending OnSystemRequest in case if RPC service is protected
Set USB INI Configurations in the .ini
Unit test "app_services_commands_test_unity" FAILED on develop branch
Audio Stream cutoff when using pipe streaming
Audio stream internal data stream error when using socket streaming
Wrong processing of SetDisplayLayout response data
Core crash during ignition_off by ATF script execution
SDL does not send GENERIC_ERROR in case HMI does NOT respond during +<RPCs_internal_timeout>
Pipe Streaming Thread Blocks Indefinitely
SDL is unable to start protected Audio/Video service in multi-transport configuration
SDL sends UPDATE_NEEDED even if app is not registered yet
Rare SDL Core crash upon termination
SDL respond with not supported resultCode = UNSUPPORTED_RESOURCE for ChangeRegistration
Remove unused ShowCustomForm HMI RPC
ExpectPolicyTableReset unit test is unstable
Fix log severity level and various typos
Provide operation result to function file_system::CreateDirectory
Application does not retrieve subscriptions to app service after resumption