Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/3178 crash on shutdown #3382

Closed
wants to merge 3 commits into from
Closed

Fix/3178 crash on shutdown #3382

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d226a0
SDLCORE-534: Changed behavior of destruction for thread and delegate …
Mar 13, 2019
516d263
SDLCORE-679: SDL crash on set_delegate on shutdown
Aug 1, 2019
ff86359
Merge remote-tracking branch 'origin/develop' into fix/3178_crash_on_…
LuxoftAKutsan Sep 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/include/utils/threads/message_loop_thread.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,9 @@ MessageLoopThread<Q>::MessageLoopThread(const std::string& name,
template <class Q>
MessageLoopThread<Q>::~MessageLoopThread() {
Shutdown();
delete thread_delegate_;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thread delegate must be deleted before the thread itself. All threads in the project follow this pattern

threads::DeleteThread(thread_);
thread_ = NULL;
Copy link
Contributor

@AByzhynar AByzhynar May 20, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LuxoftAKutsan Why did you set thread_ pointer to NULL after deletion but did not set thread_delegate_ to NULL after deletion? It is a pointer as well.

delete thread_delegate_;
}

template <class Q>
Expand Down