Main menu updating and pagination #3455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iCollin
reviewed
Jul 23, 2020
..._plugins/sdl_rpc_plugin/include/sdl_rpc_plugin/commands/hmi/on_ui_update_file_notification.h
Outdated
Show resolved
Hide resolved
...gins/sdl_rpc_plugin/include/sdl_rpc_plugin/commands/hmi/on_ui_update_sub_menu_notification.h
Outdated
Show resolved
Hide resolved
..._plugins/sdl_rpc_plugin/include/sdl_rpc_plugin/commands/mobile/on_update_file_notification.h
Outdated
Show resolved
Hide resolved
...gins/sdl_rpc_plugin/include/sdl_rpc_plugin/commands/mobile/on_update_sub_menu_notification.h
Outdated
Show resolved
Hide resolved
...cation_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/on_ui_update_file_notification.cc
Outdated
Show resolved
Hide resolved
...on_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/on_ui_update_sub_menu_notification.cc
Outdated
Show resolved
Hide resolved
...cation_manager/rpc_plugins/sdl_rpc_plugin/src/commands/mobile/on_update_file_notification.cc
Outdated
Show resolved
Hide resolved
...on_manager/rpc_plugins/sdl_rpc_plugin/src/commands/mobile/on_update_sub_menu_notification.cc
Outdated
Show resolved
Hide resolved
Co-authored-by: Collin <iCollin@users.noreply.github.com>
iCollin
approved these changes
Aug 6, 2020
…updating # Conflicts: # tools/rpc_spec
Jack-Byrne
commented
Aug 14, 2020
5 tasks
iCollin
approved these changes
Aug 17, 2020
…updating # Conflicts: # src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/hmi_command_factory.cc # src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/mobile_command_factory.cc # src/components/interfaces/HMI_API.xml # tools/rpc_spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3212
This PR is not ready for review.
Still need to add unit test changes.
Risk
This PR makes minor API changes.
Summary
Implements proposal 0268-main-menu-updating
CLA