Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/Add reason param to All protocol NAKs #3462

Merged
merged 19 commits into from
Sep 4, 2020
Merged

Feature/Add reason param to All protocol NAKs #3462

merged 19 commits into from
Sep 4, 2020

Conversation

ShobhitAd
Copy link
Contributor

@ShobhitAd ShobhitAd commented Jul 20, 2020 •
edited
Loading

Fixes #3434

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

  • ATF
  • Manual testing using test_suite

Summary

  • Add reason param to the StartService and EndService NAK payloads
  • Add a reason string for all NAK cases in SDL
  • Bump protocol version to 5.3.0

CLA

iCollin
iCollin reviewed Jul 29, 2020
View reviewed changes
@iCollin
Copy link
Collaborator

iCollin commented Aug 18, 2020

Hey @ShobhitAd, updates look good for the most part. I left one new comment, and also one more reply here. I also see some unit tests failing:

[  FAILED  ] 6 tests, listed below:
[  FAILED  ] ProtocolHandlerImplTest.StartSession_Unprotected_SessionObserverReject
[  FAILED  ] ProtocolHandlerImplTest.StartSession_Protected_SessionObserverReject
[  FAILED  ] ProtocolHandlerImplTest.StartSession_Unprotected_Multiple_SessionObserverAcceptAndReject
[  FAILED  ] ProtocolHandlerImplTest.StartSession_Audio_RejectByTransportType
[  FAILED  ] ProtocolHandlerImplTest.StartSession_Video_RejectByTransportType
[  FAILED  ] ProtocolHandlerImplTest.EndSession_SessionObserverReject

@RHenigan RHenigan mentioned this pull request Aug 27, 2020
Merged
5 tasks
@ShobhitAd ShobhitAd merged commit b94d63a into develop Sep 4, 2020
@ShobhitAd ShobhitAd deleted the feature/protocol_nak_reason_param branch September 4, 2020 16:43
@ShobhitAd ShobhitAd mentioned this pull request Sep 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jack-Byrne Jack-Byrne Jack-Byrne approved these changes

@iCollin iCollin iCollin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShobhitAd @iCollin @Jack-Byrne