-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boost Logger Implementation #3571
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to make building Core with the boost logger not require sudo?
When building with Boost, I see this warning in the cmake output, could we suppress this?
+CMake Warning (dev) at src/components/utils/CMakeLists.txt:137 (add_dependencies):
+ Policy CMP0046 is not set: Error on non-existent dependency in
+ add_dependencies. Run "cmake --help-policy CMP0046" for policy details.
+ Use the cmake_policy command to set the policy and suppress this warning.
+
+ The dependency target "install-3rd_party_logger" of target "Utils" does not
+ exist.
+This warning is for project developers. Use -Wno-dev to suppress it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is sudo necessary for the boost install?
I don't think The install target could be changed but it would end up affecting more than just the boost libraries(libbson and log4cxx). That said, it looks like |
src/appMain/main.cc
Outdated
if (!utils::appenders_loader.Loaded()) { | ||
SDL_LOG_ERROR("Appenders plugin not loaded, file logging disabled"); | ||
} | ||
#endif // LOG4CXX_LOGGER |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems this section causes the build to fail if ENABLE_LOG=OFF
, maybe move it into the ENABLE_LOG
ifdef?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved in 770ef06
This PR is ready for review.
Risk
This PR makes no API changes.
Summary
Implements a third party logger for sdl core
CLA