Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close namespace #3574

Merged
merged 1 commit into from
Nov 19, 2020
Merged

Close namespace #3574

merged 1 commit into from
Nov 19, 2020

Conversation

iCollin
Copy link
Collaborator

@iCollin iCollin commented Nov 16, 2020 •
edited
Loading

Fixes CPPCHECK

This PR is ready for review.

Background

please see discussion here to know why this was originally changed

Testing Plan

cd sdl_core
cppcheck --force -isrc/3rd_party -isrc/3rd_party-static --quiet --error-exitcode=1 src

watch for src/components/smart_objects/test/SmartObjectConvertionTime_test.cc:55]: (error) Invalid number of character '{' when no macros are defined. which should be observed before this PR but not after

CLA

@iCollin iCollin merged commit d1dcdc1 into develop Nov 19, 2020
@iCollin iCollin deleted the fix/cppcheck branch November 19, 2020 15:33
@Jack-Byrne Jack-Byrne mentioned this pull request Mar 18, 2021
Merged
1 task
@jacobkeeler jacobkeeler changed the title close namespace Close namespace Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShobhitAd ShobhitAd ShobhitAd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iCollin @ShobhitAd