Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Revoked App Consent Activation #3592

Merged
merged 7 commits into from
Jan 11, 2021

Conversation

ShobhitAd
Copy link
Contributor

Fixes #3580

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

Manual Testing with Test suite app

Summary

  • Add permissions check in OnAllowSDLFunctionalityNotification for application revoked case

CLA

Copy link
Contributor

@jacobkeeler jacobkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can still reproduce the issue on this branch

@ShobhitAd ShobhitAd merged commit 8be4f32 into develop Jan 11, 2021
@ShobhitAd ShobhitAd deleted the fix/revoked_app_consent_activation branch January 11, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants