Remove logic sending invalid slider position #3697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sliderPosition was set to 0 (an invalid value) in the mobile response if an ABORTED result was received from the HMI without this parameter.
1 task
|
@jacobkeeler Do you think we might need to add documentation to the integration guidelines or update the HMI API description to note that TIMEOUT and ABORTED result codes that include the slider position must be sent in a success response format? |
Jack-Byrne
approved these changes
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3676
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Manual testing against SDL HMI PR (smartdevicelink/sdl_hmi#564), app should receive sliderPosition in ABORTED or TIMED_OUT response for Slider if provided by the HMI.
Summary
sliderPosition was being set to 0 (an invalid value) in the mobile response for Slider if an ABORTED or TIMED_OUT result was received from the HMI without this parameter. This PR removes that logic.
Changelog
Bug Fixes
CLA