[SDL 0205] Avoid custom button subscription by default #3744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was removed subscription to custom button by default. Also, added check if app is actually subscribed to CUSTOM_BUTTON like for all other buttons.
…_subscription_logic Fix CUSTOM_BUTTON subscription logic
…f_button_subscriptions Separate subscription processing logic for mobile requests and resumption
|
@jordynmackool this PR is ready for review and is approved by Ford. |
iCollin
reviewed
Aug 5, 2021
|
Could you please merge in the 0192 feature branch? |
…cription_response_from_hmi' into feature/sdl_0205_custom_button_subscription
|
Now that 0192 is merged could you please merge in develop? |
…ustom_button_subscription
iCollin
reviewed
Aug 13, 2021
...nager/rpc_plugins/sdl_rpc_plugin/test/commands/mobile/register_app_interface_request_test.cc
Show resolved
Hide resolved
iCollin
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ NOTE ❗ : This implementation is based on Button subscription response from HMI, so this PR should be merged AFTER #3743
Fixes #2789
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
ATF tests
Unit tests
Summary
In this PR SDL send SubscribeButtons(CUSTOM_BUTTON) only if CUSTOM_BUTTON is supported by hmi_capabilities.
CLA