-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method for delete empty message #3751
Add method for delete empty message #3751
Conversation
@theresalech this PR is ready for Livio review |
@AKalinich-Luxoft A few other items that could be empty, should we cover these as well?
|
Hi @AKalinich-Luxoft , can you please review and respond to Jacob's comment? We are looking to complete development for the Core 8.0 release soon, so will need to make progress on this PR quickly in order to ensure its inclusion in the release. Thank you! |
@theresalech Luxoft is working on the fix and going to provide extra changes according to Livio comments above. |
@AKalinich-Luxoft I noticed there were some updates for this pr, is this one ready for review? |
@JackLivio Yes, PR in core is ready for review. Please also consider related update in scripts: smartdevicelink/sdl_atf_test_scripts#2573 |
@jacobkeeler this fix has been updated to extend the cut-off logic on empty structures like above. See 8407ab0 |
src/components/application_manager/src/message_helper/message_helper.cc
Outdated
Show resolved
Hide resolved
Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
Fixes #3368
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Reproduction Steps
Expected Behavior
for GetVehicleData:
SDL does respond
GENERIC_ERROR
to mobilefor OnVehicleData:
SDL does ignore this notification and SDL does not send OnVehicleData notifications to the mobile app.
Observed Behavior
for GetVehicleData:
SDL responds
SUCCESS
to mobilefor OnVehicleData:
SDL does not ignore this notification and sends OnVehicleData notification to mobile app.
Summary
Implementation on SDL side has been updated to ignore optional parameters containing the empty structures.
CLA