Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method for delete empty message #3751

Conversation

AKalinich-Luxoft
Copy link
Contributor

@AKalinich-Luxoft AKalinich-Luxoft commented Aug 2, 2021

Fixes #3368

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

Reproduction Steps
  1. HMI sends array with empty structure { {} } in fuelRange on GetVehicleData_response / OnVehicleData_notification to SDL
Expected Behavior

for GetVehicleData:
SDL does respond GENERIC_ERROR to mobile
for OnVehicleData:
SDL does ignore this notification and SDL does not send OnVehicleData notifications to the mobile app.

Observed Behavior

for GetVehicleData:
SDL responds SUCCESS to mobile
for OnVehicleData:
SDL does not ignore this notification and sends OnVehicleData notification to mobile app.

Summary

Implementation on SDL side has been updated to ignore optional parameters containing the empty structures.

CLA

@AKalinich-Luxoft
Copy link
Contributor Author

@theresalech this PR is ready for Livio review

@jacobkeeler
Copy link
Contributor

jacobkeeler commented Aug 5, 2021

@AKalinich-Luxoft A few other items that could be empty, should we cover these as well?

  • climateData
  • gearStatus
  • tirePressure
  • beltStatus
  • deviceStatus
  • stabilityControlsStatus
  • seatOccupancy

@theresalech
Copy link
Contributor

Hi @AKalinich-Luxoft , can you please review and respond to Jacob's comment? We are looking to complete development for the Core 8.0 release soon, so will need to make progress on this PR quickly in order to ensure its inclusion in the release. Thank you!

@AKalinich-Luxoft
Copy link
Contributor Author

@theresalech Luxoft is working on the fix and going to provide extra changes according to Livio comments above.

@Jack-Byrne
Copy link
Collaborator

@AKalinich-Luxoft I noticed there were some updates for this pr, is this one ready for review?

@dboltovskyi
Copy link
Contributor

@JackLivio Yes, PR in core is ready for review. Please also consider related update in scripts: smartdevicelink/sdl_atf_test_scripts#2573

@AKalinich-Luxoft
Copy link
Contributor Author

@AKalinich-Luxoft A few other items that could be empty, should we cover these as well?

  • climateData
  • gearStatus
  • tireStatus
  • beltStatus
  • deviceStatus
  • stabilityControlsStatus
  • seatOccupancy

@jacobkeeler this fix has been updated to extend the cut-off logic on empty structures like above. See 8407ab0

Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
@jacobkeeler jacobkeeler merged commit 7912ecb into smartdevicelink:develop Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants