Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix result codes of CreateInteractionChoiceSet response #3901

Conversation

OlhaVorobiova
Copy link
Contributor

Fixes #3858

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

Atf scripts

Summary

Added checks for successful results
Added parameter in two methods

CLA

@OlhaVorobiova
Copy link
Contributor Author

@theresalech this PR is ready for Livio review

@theresalech
Copy link
Contributor

@OlhaVorobiova thanks for letting us know! We are currently focused on preparing for next week's release of Core 8.1, but will look to include this fix in a future release of SDL Core.

@jacobkeeler jacobkeeler deleted the branch smartdevicelink:release/8.1.0 April 13, 2022 14:31
@jacobkeeler jacobkeeler reopened this Apr 14, 2022
@jacobkeeler
Copy link
Contributor

Closing since #3907 was created

@LitvinenkoIra LitvinenkoIra deleted the fix/sdl_sends_wrong_CreateInteractionChoiceSet_response branch June 16, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants