Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/Optimize Boost Logger Implementation #3941

Merged
merged 2 commits into from
Aug 26, 2022
Merged

Fix/Optimize Boost Logger Implementation #3941

merged 2 commits into from
Aug 26, 2022

Conversation

ShobhitAd
Copy link
Contributor

@ShobhitAd ShobhitAd commented Aug 17, 2022 •
edited
Loading

Partially Fixes #3709

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

To test performance

  • Build with -DLOGGER_NAME=BOOST
  • Start Core, deploy_server.sh and HMI. In a separate terminal tab/window run htop (Use F4 to filter for command smartDeviceLinkCore)
  • Register navigation app and start video streaming.

htop shows the CPU usage under "CPU%"

Summary

  • Use mutable attributes instead of adding attributes for every pushLog
  • Simplified how function trace is filtered.

CLA

@ShobhitAd ShobhitAd changed the title [WIP] Fix/Optimize Boost Logger Implementation Fix/Optimize Boost Logger Implementation Aug 26, 2022
@ShobhitAd ShobhitAd merged commit 8dbee74 into develop Aug 26, 2022
@ShobhitAd ShobhitAd deleted the fix/optimize_boost_logger_implementation branch August 26, 2022 18:19
@ShobhitAd ShobhitAd mentioned this pull request Aug 26, 2022
Open
@jacobkeeler jacobkeeler mentioned this pull request Sep 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobkeeler jacobkeeler jacobkeeler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShobhitAd @jacobkeeler