Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migrating to 8.0 guide #133

Merged
merged 6 commits into from
Oct 7, 2021
Merged

Add migrating to 8.0 guide #133

merged 6 commits into from
Oct 7, 2021

Conversation

Jack-Byrne
Copy link
Collaborator

Add information to highlight important integration updates. This guide includes updates to the accepted environments, configuration options, and HMI API updates integrators will need to take note of.

<function name="UnsubscribeButton" messagetype="response"></function>

```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably include a section for the behavior changes for the phone call event here:

OnEventChanged (PHONE_CALL)

The behavior of the PHONE_CALL event was changed to only affect the audioStreamingState of an app. Rather than automatically deactivating the active app, SDL Core will now only change the audioStreamingState of all apps to NOT_AUDIBLE when BC.OnEventChanged(PHONE_CALL, active=true) is sent, leaving each app's hmiLevel unchanged. This allows the HMI to start a phone call in the background without leaving the app screen, if desired.

The HMI can still control the hmiLevel of the app during a phone call event by sending BC.OnAppDeactivated(appID) and BC.OnAppActivated(appID) where appropriate.

Jack-Byrne and others added 2 commits October 6, 2021 16:36
Co-authored-by: Collin <iCollin@users.noreply.github.com>
@@ -87,6 +87,9 @@
},
{
"name": "Migrating SDL Core 7.0 to 7.1"
},
{
"name": "Migrating SDL Core 7.1 to 8.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to also add a link to this guide in the overview page https://smartdevicelink.com/en/guides/core/overview/#migrating-to-newer-sdl-versions

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment on lines 113 to 119
The parameters in the notification have also changed.

The parameter `requestID` is used instead of appID to identify which specific request should have its timeout extended.

The parameter `methodName` should include the interface name and the rpc. For example: `”TTS.Speak”`.

The parameter `resetPeriod` allows the HMI to specify how long Core should delay the application request’s timeout.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The parameters in the notification have also changed.
The parameter `requestID` is used instead of appID to identify which specific request should have its timeout extended.
The parameter `methodName` should include the interface name and the rpc. For example: `”TTS.Speak”`.
The parameter `resetPeriod` allows the HMI to specify how long Core should delay the application request’s timeout.
The parameters in the notification have also changed:
- The parameter `requestID` is used instead of appID to identify which specific request should have its timeout extended.
- The parameter `methodName` should include the interface name and the rpc. For example: `”TTS.Speak”`.
- The parameter `resetPeriod` allows the HMI to specify how long Core should delay the application request’s timeout.

Copy link
Contributor

@theresalech theresalech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JackLivio please let me know if you have any questions about my feedback. Thanks!

Jack-Byrne and others added 3 commits October 7, 2021 12:08
Co-authored-by: theresalech <theresa@livio.io>
Co-authored-by: Shobhit Adlakha <ShobhitAd@users.noreply.github.com>
@Jack-Byrne Jack-Byrne merged commit af8395c into develop Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants