Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMI sets forwardSeekIndicator and backSeekIndicator parameters for multiple Apps during SetMediaClockTimer request #519

Closed
VjKlepikov opened this issue Mar 17, 2021 · 9 comments
Assignees
Labels
5.5.0 Release issues introduced by 5.5.0 release candidate bug

Comments

@VjKlepikov
Copy link
Contributor

VjKlepikov commented Mar 17, 2021

Description:
HMI sets forwardSeekIndicator and backSeekIndicator parameters for multiple Apps during SetMediaClockTimer request from App1

Precondition:
1. SDL and HMI are started
2. App1 and App2 with HMI type 'Media' are registered
3. App1 is activated
4. App1 sends SetMediaClockTimer RPC with:
"updateMode":"COUNTUP",
"startTime": { "hours":0, "minutes":15, "seconds":30 },
"backSeekIndicator": {"seekTime":30,"type":"TIME" },
"forwardSeekIndicator": { "seekTime":30,"type":"TIME"}
5. The seek indicators are "TIME" for App1
'SEEKLEFT' button with "ico_seek_left.png" image is observed on HMI
'SEEKRIGHT' button with "ico_seek_right.png" image is observed on HMI

Steps to reproduce:

  1. Activate App2

Expected result:

  1. App2 is activated successfully
  2. By default the seek indicators are "TRACK":
    SEEKLEFT' button with "ico_prew.png" image is observed on HMI for App2
    'SEEKRIGHT' button with "Ico_next.png" image is observed on HMI for App2

Actual result:

  1. App2 is activated successfully
  2. The seek indicators are "TIME"
    'SEEKLEFT' button with "ico_seek_left.png" image is observed on HMI
    'SEEKRIGHT' button with "ico_seek_right.png" image is observed on HMI
    App2

Environment:
SDL: https://github.com/smartdevicelink/sdl_core/tree/develop (fed2ae4)
HMI: https://github.com/smartdevicelink/sdl_hmi/tree/develop (ad2dc80)
SPT: 20210305-Android (1076)

@VjKlepikov
Copy link
Contributor Author

VjKlepikov commented Mar 17, 2021

@jordynmackool, Please notice this issue is related to feature Media Skip Indicators that should be released in the 7.1 release.

@VjKlepikov VjKlepikov changed the title HMI sets forwardSeekIndicator and backSeekIndicator parameters for multiple Apps during SetMediaClockTimer request from App1 HMI sets forwardSeekIndicator and backSeekIndicator parameters for multiple Apps during SetMediaClockTimer request Mar 17, 2021
@Ypostolov
Copy link
Contributor

Luxoft is working on it.

@jordynmackool
Copy link

@Ypostolov please note @jacobkeeler may have already started working on a fix for this reported bug. Please allow me a day to confirm before you continue working on a fix so efforts are not duplicated.

@jordynmackool jordynmackool added the 5.5.0 Release issues introduced by 5.5.0 release candidate label Mar 22, 2021
@jacobkeeler
Copy link
Contributor

@Ypostolov I was able to investigate the issue for a while on Thursday, but I wasn't able to find the actual root cause as of yet. I should be able to take on another task if Luxoft is planning on looking into the fix. Some notes I have from my investigation:

  1. The reproduction steps are rather specific. If you set streaming indicators for both apps, the HMI sets them correctly from that point on.
  2. Looking in the debugging console, it looks like the model for app2 actually has forwardSeekIndicator and backSeekIndicator set to {"seekTime":30,"type":"TIME"} in the scenario given, same as app1. This leads me to believe that parts of the model for app1 and app2 are tied together initially (possibly because of some nuance in how javascript and/or ember-js stores data).

@jordynmackool
Copy link

Thanks, @jacobkeeler. @Ypostolov, please let me know when a PR is ready for Livio review.

@jordynmackool
Copy link

@Ypostolov please advise when the fix for this issue will be ready for Livio review?

@LitvinenkoIra LitvinenkoIra self-assigned this Mar 31, 2021
@LitvinenkoIra
Copy link
Contributor

@jordynmackool fix for this issue is currently in progress and will be ready for Livio review by the end of this week

@LitvinenkoIra
Copy link
Contributor

@jacobkeeler Fix is ready for Livio review. Thank you.

@jacobkeeler
Copy link
Contributor

Closing with the merge of #550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.5.0 Release issues introduced by 5.5.0 release candidate bug
Projects
None yet
Development

No branches or pull requests

5 participants