Fix UNSUPPORTED_RESOURCE result code for images #450
Conversation
Make HMI to respond with the proper result code in case when STATIC image is received. Also removed redundant and commented code to make things cleaner.
There was noticed a regression that HMI does not forward params in case of error. This is because of complicated and wrong logic of calculation of some corner cases. To avoid that, condition was reformatted as a more readable separate function.
|
@AKalinich-Luxoft, given the size of these changes and time constraints (Steering Committee is currently reviewing Core 7.0 Release Candidate for approval, and release of both Core 7.0 and SDL HMI 5.4 are planned for tomorrow, 11/5), we will plan to review this PR for the following SDL HMI release. |
| requestID, | ||
| 'UI.PerformInteraction', | ||
| info, | ||
| params |
There was a problem hiding this comment.
As a note, if a PerformInteraction request is sent with MANUAL_ONLY, Core will mark the response as success: false if an UNSUPPORTED_RESOURCE code is sent.
There was a problem hiding this comment.
Seems this is the case with Alert as well.
There was a problem hiding this comment.
@AKalinich-Luxoft Perhaps we should keep it so these cases return WARNINGS for now? That or we could submit a fix for this issue alongside this PR. Let me know your thoughts on the matter
There was a problem hiding this comment.
@jacobkeeler so the fix was to return UNSUPPORTED_RESOURCE instead of WARNINGS in these cases.
Regarding success:false - do you mean wrong SDL behavior in that case? If so, I agree that new SDL issue should be created and we can work on fix for that further
There was a problem hiding this comment.
@jacobkeeler I also see the issues like smartdevicelink/sdl_core#1596 which looks like describe the same case
There was a problem hiding this comment.
hmm, don't know exactly what happened with that issue, the one difference in the description is that it specifies is that UNSUPPORTED_RESOURCE is sent for VR.PerformInteraction instead of UI.PerformInteraction. At the moment, it looks like the SDL HMI will send WARNINGS for VR.PerformInteraction if unsupported phonemes are used, so it's possible that I attempted that and misinterpreted the results. Seems that the issue is still present though, so I will reopen the issue.
There was a problem hiding this comment.
Alright, I think I can approve this PR for now and I'll submit a fix for smartdevicelink/sdl_core#1596 to go along with this
Fixes #443 and #442 and #445
This PR is ready for review.
Testing Plan
Covered by manual tests
Summary
Make HMI to respond with the proper result code in case when STATIC image is received. Also removed redundant and commented code to make things cleaner.
CLA