Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main Menu UI Updates #476

Merged
merged 5 commits into from
Feb 11, 2021
Merged

Main Menu UI Updates #476

merged 5 commits into from
Feb 11, 2021

Conversation

Jack-Byrne
Copy link
Collaborator

@Jack-Byrne Jack-Byrne commented Jan 11, 2021

Implements SDL Core Issue 3195

This PR is ready for review.

Testing Plan

Send AddSubmenus and AddCommands with additional fields populated.

Summary

Adds extra text and image fields to menu items.

CLA

@ShobhitAd
Copy link
Contributor

ShobhitAd commented Jan 15, 2021

I ran into some UI issues while testing AddCommand. These issues also apply to AddSubMenu

  1. Requests with tertiaryText and no icons: The tertiary text at the end is cut off
    AddCommand1

  2. Requests with cmdIcon/menuIcon but no secondaryImage: There is an empty box with a white outline in div.end-info
    AddCommand2

  3. Requests with secondaryImage but no cmdIcon/menuIcon: The secondaryImage in div.end-info is stretched horizontally
    AddCommand3

@ShobhitAd
Copy link
Contributor

The new text field and image fields should also be added to the UI capabilities https://github.com/smartdevicelink/sdl_hmi/blob/develop/ffw/UIRPC.js#L635

@ShobhitAd
Copy link
Contributor

ShobhitAd commented Jan 27, 2021

The new text field and image fields should also be added to the UI capabilities https://github.com/smartdevicelink/sdl_hmi/blob/develop/ffw/UIRPC.js#L635

Sorry, it looks like app/model/sdl/Abstract/data.js is used for OnSystemCapabilityUpdated(DISPLAY) notifcations from the sdl_hmi. The changes from ddecefc will also have to be added to app/model/sdl/Abstract/data.js

@Jack-Byrne Jack-Byrne merged commit 92af7cb into develop Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants