Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JS Docs for setVoiceCommand #449

Merged
merged 1 commit into from
May 26, 2021
Merged

Fix JS Docs for setVoiceCommand #449

merged 1 commit into from
May 26, 2021

Conversation

renonick87
Copy link
Contributor

Fixes #448

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have verified that this PR passes lint validation
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Changelog

Bug Fixes
  • This PR fixes the JS Docs for VoiceCommandManager setVoiceCommand to correctly state that the Promise returned resolves after the task to update the commands has been added to the task queue.

CLA

@renonick87 renonick87 merged commit 5a07729 into develop May 26, 2021
@renonick87 renonick87 deleted the bugfix/set-voice-commands-docs-fix branch May 26, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crokita crokita crokita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JS Docs for VoiceCommandManager setVoiceCommands say that the method resolves later than it actually does
2 participants
@renonick87 @crokita