Feature/menu manager #482
Merged
Feature/menu manager #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…script_suite into feature/menu-manager
…script_suite into feature/menu-manager
Contributor
Author
|
This is now ready for review |
renonick87
requested changes
Sep 16, 2021
Co-authored-by: renonick87 <nick@livioradio.com>
renonick87
requested changes
Sep 22, 2021
Co-authored-by: renonick87 <nick@livioradio.com>
renonick87
reviewed
Sep 23, 2021
Contributor
renonick87
left a comment
renonick87
left a comment
There was a problem hiding this comment.
The _MenuCellState description looks to be on the DynamicMenuUpdatesMode file.
Co-authored-by: renonick87 <nick@livioradio.com>
renonick87
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #123
Risk
This PR makes minor API changes.
Testing Plan
Unit Tests
Adds tests relating to menu manager operation
Summary
Adds a menu manager to the library, aligning with the iOS and Java Suite libraries.