fix: always serialize defaults #1315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauzadis
reviewed
Jul 7, 2025
Comment on lines
+56
to
+57
| val settings = defaultModel.defaultSettings(defaultValueSerializationMode = DefaultValueSerializationMode.WHEN_DIFFERENT) | ||
| val contents = getTestContents(defaultModel, "com.test#PrimitiveShapesOperation", HttpBinding.Location.HEADER, settings) |
Contributor
There was a problem hiding this comment.
I still think we should have tests for the new behavior
Contributor
Author
There was a problem hiding this comment.
We already had/have tests which explicitly set ALWAYS. My changes in this PR make all of the implicit WHEN_DIFFERENT values into explicit ones. Are there specific tests you'd like to see added/expanded?
Contributor
There was a problem hiding this comment.
Oh right, I totally missed the names of the tests here. These are perfectly fine
This comment has been minimized.
This comment has been minimized.
lauzadis
approved these changes
Jul 7, 2025
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Resolves aws/aws-sdk-kotlin#1608
Description of changes
This change is identical to #1302 but has been rebased onto v1.5-main since it is a behavioral breaking change.
This change switches the default serialization mode from
WHEN_DIFFERENT(meaning only if the value has been changed from the default) toALWAYS(meaning...well, always). This is the current recommendation from Smithy and will offer more deterministic communication with services.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.