Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecations from rust-runtime #3222

Merged
merged 8 commits into from
Nov 17, 2023

Conversation

jdisanti
Copy link
Collaborator

@jdisanti jdisanti commented Nov 17, 2023

This PR removes deprecations throughout smithy-rs client and the SDK. Some of these deprecations were ignored by the compiler (in the case where #[deprecated] was used with pub use), so these will need to be explicitly called out in the changelog.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@jdisanti jdisanti force-pushed the jdisanti-remove-deprecations branch from e34f580 to 63bc762 Compare November 17, 2023 01:34
@jdisanti jdisanti force-pushed the jdisanti-remove-deprecations branch from 63bc762 to bb09ba7 Compare November 17, 2023 01:49
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@jdisanti jdisanti added needs-sdk-review breaking-change This will require a breaking change labels Nov 17, 2023
@jdisanti jdisanti marked this pull request as ready for review November 17, 2023 02:11
@jdisanti jdisanti requested review from a team as code owners November 17, 2023 02:11
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

Copy link
Contributor

@ysaito1001 ysaito1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jdisanti jdisanti enabled auto-merge November 17, 2023 16:52
@jdisanti jdisanti disabled auto-merge November 17, 2023 16:52
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@rcoh rcoh changed the base branch from main to rollup-merge-11-17 November 17, 2023 18:45
@rcoh rcoh merged commit 9e09fa4 into rollup-merge-11-17 Nov 17, 2023
4 checks passed
@rcoh rcoh deleted the jdisanti-remove-deprecations branch November 17, 2023 18:47
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

aws-sdk-rust-ci pushed a commit that referenced this pull request Nov 17, 2023
This PR removes deprecations throughout smithy-rs client and the SDK.
Some of these deprecations were ignored by the compiler (in the case
where `#[deprecated]` was used with `pub use`), so these will need to be
explicitly called out in the changelog.

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._

---------

Co-authored-by: Russell Cohen <rcoh@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This will require a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants