Add a RuntimePlugin/Interceptor to enforce expected content length #3491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
force-pushed
the
length-enforcing-body
branch
from
fcb33cd to
dcb0c0a
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
reviewed
Mar 19, 2024
| #[pin] | ||
| body: InnerBody, | ||
| expected_length: u64, | ||
| remaining_length: i64, |
There was a problem hiding this comment.
The u64/i64 difference with all the casting seems fragile to me. Why not just do a checked subtraction and error out if it would go below zero? Or, alternatively, change this from "remaining" to "received" and use addition instead.
There was a problem hiding this comment.
good idea! that lead to a nice simplification
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
force-pushed
the
length-enforcing-body
branch
2 times, most recently
from
d3dacb3 to
9be92d9
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
force-pushed
the
length-enforcing-body
branch
from
88a1301 to
2fad245
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
Precommit hooks and CI have started failing due to `runtime-versioner` reporting `aws-config` requires a version bump. While the most recent change to that crate was made by [this PR](#3491) only updating test-related code, it does still require a version bump. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
1 task
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 13, 2024
## Motivation and Context This PR re-enables content-length runtime plugin that was previously disabled due to some erroneous tests. Those [tests](https://github.com/awslabs/aws-sdk-rust/blob/main/sdk/dynamodb/tests/retries-with-client-rate-limiting.rs#L29) appear to be fixed. Original PR: #3491 Tracking issue: #3523 ## Checklist <!--- If a checkbox below is not applicable, then please DELETE it rather than leaving it unchecked --> - [x] I have updated `CHANGELOG.next.toml` if I made changes to the smithy-rs codegen or runtime crates ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
There is a rarely-triggered bug (awslabs/aws-sdk-rust#1079) that can occur when the runtime is dropped between requests. Although this is definitely the wrong thing to do(tm) which should still aim to at least protect the users from bad data in this case.
This adds an interceptor which validates that the body returned is the correct length.
Description
Testing
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.